1380175 - Update Widevine CDM to version 970

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, enhancement)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

We have a new Widevine CDM version 1.4.8.970 to deploy on desktop.

Please update the balrog rules for Firefox 56 (currently in Nightly) as follows:

Linux 32bit
URL: https://redirector.gvt1.com/edgedl/widevine-cdm/970-linux-ia32.zip
SHA512: 7f66257164909f5f41ffc2f18b832f7cbaada1db444b4a118df0a4018b4b177bbacd91d0df8b3d4e665448b96a8604485dd57e63bc28bccf638fbf7c9faa5ac5
FileSize: 2296162

Linux 64bit
URL: https://redirector.gvt1.com/edgedl/widevine-cdm/970-linux-x64.zip
SHA512: 7a5e5b500264478bd860e6a490995d00c5b065891d7538352f7b930bd75b614738cd4e9058f717d1432cec076e1d5d4aa5bed080d3c8a92b928da203a207ba69
FileSize: 2210161

MacOS 10.9 and later
URL: https://redirector.gvt1.com/edgedl/widevine-cdm/970-mac-x64.zip
SHA512: e96daedccbb318ff4de2e2d8ffe928e0aaacec7794ca05893d37461ee11e52830c736128ecebe311e973c125ac46435ef011a82ca06f602a085bc6d43f5127c1
FileSize: 1681446

Windows 7+ 32bit
URL: https://redirector.gvt1.com/edgedl/widevine-cdm/970-win-ia32.zip
SHA512: 5d658579d19e26038a0f5305395733774aa1663c46341c599f74e18c2a84edcc2c909ef752b818b3c7eaf49c1baf7e1b56f56b701fd379e644796830029aa48f
FileSize: 2342279

Windows 7+ 64bit
URL: https://redirector.gvt1.com/edgedl/widevine-cdm/970-win-x64.zip
SHA512: 79a60aa7ff62cb0c222740d3cc5e10a5d392153bd3e4436162f35b7076ee6478206dd017a494692ded95804b8727236ac08715beb2564e3907a190b605d5ed75
FileSize: 2346464

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

I have sent notification of this update to the release-drivers mailing list.

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

I'll be taking care of this. First time I handle this kind of request so I need to gather a bit more of context but I expect an ETA by EOD tomorrow, Thursday, if that's okay. Please let me know if this is more urgent and I can defer to someone who already has context.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

EOD tomorrow is fine. Note I'm on New Zealand time, so if you have questions I'm unlikely to be as responsive on Friday Pacific time as that's Saturday here.

Comment 4

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: Widevine-1.4.8.970.json

Comment 5

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #4)
> Created attachment 8886353 [details]
> Widevine-1.4.8.970.json

Uploaded it to Balrog. Prepping the nightlytest rules in a bit.

Comment 6

[Mihai Tabara [:mtabara]⌚️GMT]

Note to self: 
* must be careful not to amend the rules as they are in the current form "Product": "no channel" as they'll affect direct firefox release. This works a bit different than the rest of release served via balrog as they are served as per version, not per channel. So as long as I specify a testing channel, I should be safe. Once testing is done, QE signs-off, we're good to go and amend the default rules.

Comment 7

[Mihai Tabara [:mtabara]⌚️GMT]

I imported the existing rule(s) from production but:
* took the "Keep OSX < 10.9 on Widevine .866 ( Bug 1287925)" (rule 386) and "Firefox < 49.0a1 stays on .866 ( Bug 1287925 )" and copy-pasted those and amended the channel to point to nightlytest
* the default rule to update points to 970 and it's as well on the nightlytest

Changes are in effect.

Testing with various urls confirmed the changes are isolated within the nightlytest only and correctly serve the 970:
* https://aus5.mozilla.org/update/3/GMP/52.0a1/20160223030304/WINNT_x86-msvc-x64/en-US/nightly/Windows_NT%2010.0.0.0%20(x64)/default/default/update.xml
* https://aus5.mozilla.org/update/3/GMP/52.0a1/20160223030304/WINNT_x86-msvc-x64/en-US/nightlytest/Windows_NT%2010.0.0.0%20(x64)/default/default/update.xml
* ...

@cpearce: what are next steps here? Is there any QE sign-off required here before we go for actual nightly channel? Is this riding the trains? (as in, before merging to beta we need to migrate these rules to beta channel, etc)

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

We don't normally do an official QE sign off. Normally what happens is I test on nightlytest, and then we push the change out to the target pre-release channel.

Note that we don't target the CDM download rules to a channel (i.e. nightly/beta/release etc), we target the Firefox version which happens to be on Nightly. So this should just ride the 56 train out to release.

I'll test the rules now, gimme a minute.

Comment 9

[Chris Pearce [:cpearce (Not reading bugmail)]]

I have tested nightlytest on Win7 x86, Win10 x86 and x64, Linux x86 and x64 and MacOSX 10.12. I don't have access to earlier versions of MacOS. I think we're good to push out the rules to Firefox 56.

Comment 10

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to Chris Pearce (:cpearce) from comment #9)
> I have tested nightlytest on Win7 x86, Win10 x86 and x64, Linux x86 and x64
> and MacOSX 10.12. I don't have access to earlier versions of MacOS. I think
> we're good to push out the rules to Firefox 56.

Sounds good! I'll proceed with this in a few hours when :bhearsum comes online and I can double-check with him that I'm setting the balrog rules correctly. Next time, the turnaround for this kind of release-request will be smaller, now that it's clear to me what needs to be done.

I'll leave the NI open until we go live.

Comment 11

[Mihai Tabara [:mtabara]⌚️GMT]

So turns out :bhearsum will come online after my EOD today so I won't be able to make the changes under his supervision. Therefore, I scheduled what I think the changes should look like, to happen on Monday, 17th, at 18:00pm, GMT. This gives :bhearsum enough time either today or Monday morning to review them.

@bhearsum:
* scheduled changes are nothing but the same three rules I've added yesterday, with channel changed from "nightlytest" to "nightly"
*  if you approve these later on today, please update the timings and let them go live sooner.
* changes are here[1]

Thank you.

[1] https://aus4-admin.mozilla.org/rules/scheduled_changes

Comment 12

[[e-mail] (:bhearsum)]

(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #11)
> So turns out :bhearsum will come online after my EOD today so I won't be
> able to make the changes under his supervision. Therefore, I scheduled what
> I think the changes should look like, to happen on Monday, 17th, at 18:00pm,
> GMT. This gives :bhearsum enough time either today or Monday morning to
> review them.
> 
> @bhearsum:
> * scheduled changes are nothing but the same three rules I've added
> yesterday, with channel changed from "nightlytest" to "nightly"
> *  if you approve these later on today, please update the timings and let
> them go live sooner.
> * changes are here[1]
> 
> Thank you.
> 
> [1] https://aus4-admin.mozilla.org/rules/scheduled_changes

The rules you've got here specify "nightly" as their channel - which I don't think is right (as cpearce mentioned, we target a product+version instead). What you need to do is transform the existing rules into the current state of the test channel. This probably means:
- Deleting rules 609 & 610 entirely (they are duplicates of 386 & 385 with "nightlytest" set)
- Updating rule 357 to set the version to <56.0a1 (to keep older users on Widevine 903)
- Updating rule 611 to remove "nightlytest" as the channel, and change the priority to be lower than rule 357, so that it doesn't take priority over the older versions.

I don't think we should ship something like on a Friday anyways, so let's reconvene Monday and make sure neither of us is missing anything.

Comment 13

[Mihai Tabara [:mtabara]⌚️GMT]

Reread https://bugzilla.mozilla.org/show_bug.cgi?id=1380175#c12 + https://bugzilla.mozilla.org/show_bug.cgi?id=1380175#c8 and it all makes sense now. I got it wrong initially.

I rearranged the scheduled changes as :bhearsum suggested https://aus4-admin.mozilla.org/rules/scheduled_changes.
Changes are scheduled to happen in 20 mins, I'll confirm again once this is done.

Comment 14

[Mihai Tabara [:mtabara]⌚️GMT]

Changes were scheduled a good 20-25 minutes ago but because of some apparent agent bug, we're still not sure if these changes took effect or not. Ben might follow up with more debugging information.

Keeping this bug open until problem is solved and :cpearce confirms all is good.

Comment 15

[[e-mail] (:bhearsum)]

(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #14)
> Changes were scheduled a good 20-25 minutes ago but because of some apparent
> agent bug, we're still not sure if these changes took effect or not. Ben
> might follow up with more debugging information.
> 
> Keeping this bug open until problem is solved and :cpearce confirms all is
> good.

https://bugzilla.mozilla.org/show_bug.cgi?id=1381557 caused some issues, but we worked around it. Everything should be live now - apologies for the delay.

Comment 16

[Chris Pearce [:cpearce (Not reading bugmail)]]

I've test this in Nightly on Windows, Mac and Linux, and it is working. Thanks!