If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Update cubeb from upstream to bb18984

RESOLVED FIXED in Firefox 56

Status

()

Core
Audio/Video: cubeb
P1
normal
Rank:
15
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: achronop, Assigned: achronop)

Tracking

unspecified
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Assignee)

Description

2 months ago
Pick commits:

bb18984 Alex Chronopoulos       New test for undefined layout on output
7590a1e Alex Chronopoulos       Skip mixing when layout is set to undefined
3cd65d2 Chun-Min Chang  Add an API to reset audio stream to the default device
0070c11 Chun-Min Chang  Fix mixer warnings
dd75e6c Dan Glastonbury Use consistent types for channels, rate, and latency in API.
d16db3b Dan Glastonbury Change cubeb_get_min_latency to take params via pointer.
Blocks: 1361336
(Assignee)

Updated

2 months ago
Assignee: nobody → achronop
Blocks: 1378070
Rank: 15
Priority: -- → P1
(Assignee)

Comment 1

2 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6de1a6add271
(Assignee)

Comment 2

2 months ago
Update also cubeb-pulse-rs. Pick commits:

3b8cfba Chun-Min Chang  Add cubeb_stream_reset_default_device to synchronize the changes of Cubeb
a60ba46 Matthew Gregan  Merge pull request #12 from djg/upstream-pa-sink-flag-fix
2ae2f7a Dan Glastonbury Upstream gecko Bug 1375873.
9c52e89 Dan Glastonbury Upstream gecko Bug 1376000
(Assignee)

Comment 3

2 months ago
Linux try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=88fd6b9a3e0faef8f6f97fc5c6389addb6291d77
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

2 months ago
Attachment #8886129 - Flags: review?(dglastonbury)

Comment 7

2 months ago
mozreview-review
Comment on attachment 8886128 [details]
Bug 1380233 - New signature for cubeb_get_min_latency.

https://reviewboard.mozilla.org/r/156930/#review162256
Attachment #8886128 - Flags: review?(kinetik) → review+

Comment 8

2 months ago
mozreview-review
Comment on attachment 8886127 [details]
Bug 1380233 - Update cubeb from upstream to bb18984.

https://reviewboard.mozilla.org/r/156928/#review162260
Attachment #8886127 - Flags: review?(kinetik) → review+

Comment 9

2 months ago
mozreview-review
Comment on attachment 8886129 [details]
Bug 1380233 - Update cubeb pulse rust backend from upstream to 3b8cfba.

https://reviewboard.mozilla.org/r/156932/#review162402

LGTM
Attachment #8886129 - Flags: review?(dglastonbury) → review+

Comment 10

2 months ago
Pushed by achronop@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/21db3e26697e
Update cubeb from upstream to bb18984. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/460a283a7b42
New signature for cubeb_get_min_latency. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/5da88708eca2
Update cubeb pulse rust backend from upstream to 3b8cfba. r=kamidphish

Comment 11

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/21db3e26697e
https://hg.mozilla.org/mozilla-central/rev/460a283a7b42
https://hg.mozilla.org/mozilla-central/rev/5da88708eca2
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
(Assignee)

Comment 12

2 months ago
That's not there yet. It depends on cubeb import but there are more to be done.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 13

2 months ago
Sorry wrong bug.
Status: REOPENED → RESOLVED
Last Resolved: 2 months ago2 months ago
Resolution: --- → FIXED
there are fewer compiler warnings after this landed:
== Change summary for alert #7943 (as of July 14 2017 05:25 UTC) ==

Improvements:

  2%  compiler warnings summary windowsxp opt      132.00 -> 130.00
  2%  compiler warnings summary windows2012-32 opt 132.00 -> 130.00
  1%  compiler warnings summary windows2012-32 pgo 142.17 -> 140.08
  1%  compiler warnings summary windows2012-32-noopt debug 137.00 -> 135.00
  1%  compiler warnings summary windowsxp debug    137.00 -> 135.00
  1%  compiler warnings summary windows2012-32 debug 137.00 -> 135.00
  1%  compiler warnings summary windows8-64 opt    152.00 -> 150.00
  1%  compiler warnings summary windows2012-64 opt 152.00 -> 150.00
  1%  compiler warnings summary windows2012-64-noopt debug 158.00 -> 156.00
  1%  compiler warnings summary windows8-64 debug  158.00 -> 156.00
  1%  compiler warnings summary windows2012-64 debug 158.00 -> 156.00
  1%  compiler warnings summary windows2012-64 pgo 162.08 -> 160.25

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=7943
(Assignee)

Comment 15

2 months ago
Yeah, Chun-Min fixed mixer warnings
You need to log in before you can comment on or make changes to this bug.