1380233 - Update cubeb from upstream to bb18984

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, enhancement, P1)

Description

[Alex Chronopoulos [:achronop]]

Pick commits:

bb18984 Alex Chronopoulos       New test for undefined layout on output
7590a1e Alex Chronopoulos       Skip mixing when layout is set to undefined
3cd65d2 Chun-Min Chang  Add an API to reset audio stream to the default device
0070c11 Chun-Min Chang  Fix mixer warnings
dd75e6c Dan Glastonbury Use consistent types for channels, rate, and latency in API.
d16db3b Dan Glastonbury Change cubeb_get_min_latency to take params via pointer.

Comment 1

[Alex Chronopoulos [:achronop]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6de1a6add271

Comment 2

[Alex Chronopoulos [:achronop]]

Update also cubeb-pulse-rs. Pick commits:

3b8cfba Chun-Min Chang  Add cubeb_stream_reset_default_device to synchronize the changes of Cubeb
a60ba46 Matthew Gregan  Merge pull request #12 from djg/upstream-pa-sink-flag-fix
2ae2f7a Dan Glastonbury Upstream gecko Bug 1375873.
9c52e89 Dan Glastonbury Upstream gecko Bug 1376000

Comment 3

[Alex Chronopoulos [:achronop]]

Linux try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=88fd6b9a3e0faef8f6f97fc5c6389addb6291d77

Comment 4

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1380233 - Update cubeb from upstream to bb18984.

Review commit: https://reviewboard.mozilla.org/r/156928/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156928/

Comment 5

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1380233 - New signature for cubeb_get_min_latency.

Review commit: https://reviewboard.mozilla.org/r/156930/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156930/

Comment 6

[Alex Chronopoulos [:achronop]]

Attachment: Bug 1380233 - Update cubeb pulse rust backend from upstream to 3b8cfba.

Review commit: https://reviewboard.mozilla.org/r/156932/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156932/

Comment 7

[Matthew Gregan [:kinetik]]

Comment on attachment 8886128 [details]
Bug 1380233 - New signature for cubeb_get_min_latency.

https://reviewboard.mozilla.org/r/156930/#review162256

Comment 8

[Matthew Gregan [:kinetik]]

Comment on attachment 8886127 [details]
Bug 1380233 - Update cubeb from upstream to bb18984.

https://reviewboard.mozilla.org/r/156928/#review162260

Comment 9

[u480271]

Comment on attachment 8886129 [details]
Bug 1380233 - Update cubeb pulse rust backend from upstream to 3b8cfba.

https://reviewboard.mozilla.org/r/156932/#review162402

LGTM

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/21db3e26697e
Update cubeb from upstream to bb18984. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/460a283a7b42
New signature for cubeb_get_min_latency. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/5da88708eca2
Update cubeb pulse rust backend from upstream to 3b8cfba. r=kamidphish

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/21db3e26697e
https://hg.mozilla.org/mozilla-central/rev/460a283a7b42
https://hg.mozilla.org/mozilla-central/rev/5da88708eca2

Comment 12

[Alex Chronopoulos [:achronop]]

That's not there yet. It depends on cubeb import but there are more to be done.

Comment 13

[Alex Chronopoulos [:achronop]]

Sorry wrong bug.

Comment 14

[Joel Maher ( :jmaher ) (UTC -8)]

there are fewer compiler warnings after this landed:
== Change summary for alert #7943 (as of July 14 2017 05:25 UTC) ==

Improvements:

  2%  compiler warnings summary windowsxp opt      132.00 -> 130.00
  2%  compiler warnings summary windows2012-32 opt 132.00 -> 130.00
  1%  compiler warnings summary windows2012-32 pgo 142.17 -> 140.08
  1%  compiler warnings summary windows2012-32-noopt debug 137.00 -> 135.00
  1%  compiler warnings summary windowsxp debug    137.00 -> 135.00
  1%  compiler warnings summary windows2012-32 debug 137.00 -> 135.00
  1%  compiler warnings summary windows8-64 opt    152.00 -> 150.00
  1%  compiler warnings summary windows2012-64 opt 152.00 -> 150.00
  1%  compiler warnings summary windows2012-64-noopt debug 158.00 -> 156.00
  1%  compiler warnings summary windows8-64 debug  158.00 -> 156.00
  1%  compiler warnings summary windows2012-64 debug 158.00 -> 156.00
  1%  compiler warnings summary windows2012-64 pgo 162.08 -> 160.25

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=7943

Comment 15

[Alex Chronopoulos [:achronop]]

Yeah, Chun-Min fixed mixer warnings