1380236 - stylo-bindings artifact confuses mozharness artifact test downloading on buildbot.

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect, P3)

Description

[Tom Prince [:tomprince]]

Compare the artifacts lists at 
https://archive.mozilla.org/pub/thunderbird/tinderbox-builds/comm-central-macosx64/1499594300/
https://archive.mozilla.org/pub/thunderbird/tinderbox-builds/comm-central-macosx64/1499684958/

The former has an additional *.stylo-bindings.zip.

testing/mozharness/mozharness/mozilla/testing/testbase.py incorrectly detects that file as a installer package which causes the tests to fail to run.

Comment 1

[Tom Prince [:tomprince]]

Attachment: Bug 1380236 - Don't treat *.stylo-bindings.zip as a potential installer;

Review commit: https://reviewboard.mozilla.org/r/156592/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156592/

Comment 2

[Tom Prince [:tomprince]]

mozilla-try-build: https://treeherder.mozilla.org/#/jobs?repo=try&revision=25dc237aa2c4e5dcdbf7d61ba856f2c78c9f697c
comm-try-build: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=44f4e902325e1ca3f0ffaa839a308de3bcb2f033

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 8885818 [details]
Bug 1380236 - Don't treat *.stylo-bindings.zip as a potential installer;

https://reviewboard.mozilla.org/r/156592/#review161728

Comment 4

[Jorg K (CEST = GMT+2)]

The patch applies to M-C, can you please get it checked in.

Comment 5

[Carsten Book [:Tomcat]]

also landed on autoland

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63df6245eaeb
Don't treat *.stylo-bindings.zip as a potential installer; r=Callek

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/63df6245eaeb

Comment 8

[Tom Prince [:tomprince]]

Attachment: stylo-bindings-is-not-package.patch

It turns out that the build wasn't passing the correct package URL, rather than the tests picking the wrong package URL from the list passed to it:
https://treeherder.mozilla.org/logviewer.html#?job_id=114511517&repo=try-comm-central&lineNumber=15325

Comment 9

[Tom Prince [:tomprince]]

Comment on attachment 8886795 [details] [diff] [review]
stylo-bindings-is-not-package.patch

Review of attachment 8886795 [details] [diff] [review]:
-----------------------------------------------------------------

Approved by Callek

Comment 10

[Jorg K (CEST = GMT+2)]

Ryan, can you land this for us. It's in the Thunderbird product, but the patch applies to M-C.

Please add the reviewer Callek.

Comment 11

[Nick Thomas [:nthomas] (UTC+12)]

It's actually a buildbotcustom change, which I'll land and merge in ~24 hours unless there is some dire burning (doesn't seem to be the case on comm- or mozilla-central).

Comment 12

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 8886795 [details] [diff] [review]
stylo-bindings-is-not-package.patch

https://hg.mozilla.org/build/buildbotcustom/rev/006ecaa5110ac70d54bdc3624e8fb8d78f7927c8
https://hg.mozilla.org/build/buildbotcustom/rev/5560d7cdca42a2e26e338a114564b251c50ce629

Comment 13

[Intermittent Failures Robot]

10 failures in 720 pushes (0.014 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* comm-central: 10

Platform breakdown:
* osx-10-10: 10

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1380236&startday=2017-07-10&endday=2017-07-16&tree=all