1380244 - A small change to the skip-to-next-key-frame policy.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Tzuhao Kuo [:kaku]]

Spawn from bug 1378691 comment 6.

http://searchfox.org/mozilla-central/rev/31311070d9860b24fe4a7a36976c14b328c16208/dom/media/MediaFormatReader.cpp#1559

Now, from the video-track point of view, when the skip-to-next-key-frame is triggered, it actually skip to the next next key frame.

Say, we are playing a media file with its playback position at time _a_ and its video decoding is falling behind at time _v_. The next key frame is at time _k1_ and next next key frame is at time _k2_.


              a
----|---------|---------|-------------|----------------> time
    v                   k1            k2


When the palyback position _a_ passes _k1_ (_a_ > _k1_), the skip-to-next-key-frame is triggered and the demuxer jumps to _k2_ directly. 



The idea here is to give a chance when _a_ == _k1_, let demuxer jump to _k1_ and see if the video decoding could catch up.

Comment 1

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1380244 - trigger skip-to-next-key-frame quicker;

Review commit: https://reviewboard.mozilla.org/r/156464/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156464/

Comment 2

[Tzuhao Kuo [:kaku]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7ad87e6fac39eca1055a6400f9520dd108d8042a

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8885608 [details]
Bug 1380244 - trigger skip-to-next-key-frame quicker;

https://reviewboard.mozilla.org/r/156464/#review161848

::: commit-message-6fec4:1
(Diff revision 1)
> +Bug 1380244 - trigger skip-to-next-key-frame quicker; r?jya

Please provide a complete commit message with description on what you're attempting to fix...
thanks.

Comment 4

[Tzuhao Kuo [:kaku]]

Comment on attachment 8885608 [details]
Bug 1380244 - trigger skip-to-next-key-frame quicker;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/156464/diff/1-2/

Comment 5

[Tzuhao Kuo [:kaku]]

Commit message is included, thanks for the review!
Try looks good, let's check in it.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be2c265f67c4
trigger skip-to-next-key-frame quicker; r=jya

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/be2c265f67c4