Convert tests within js/xpconnect to comply with new data: URI inheritance model

RESOLVED FIXED in Firefox 56

Status

()

Core
DOM: Security
P2
normal
RESOLVED FIXED
a year ago
11 months ago

People

(Reporter: ckerschb, Assigned: ckerschb)

Tracking

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

a year ago
Assignee: nobody → ckerschb
Blocks: 1324406
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [domsecurity-active]
(Assignee)

Comment 1

a year ago
Created attachment 8885603 [details] [diff] [review]
bug_1380249_update_tests_js_xpconnect.patch

Bobby, when flipping the pref |security.data_uri.unique_opaque_origin| we encounter three failing tests within js/xpconnect:
1: js/xpconnect/tests/chrome/test_bug484459.xul
2: js/xpconnect/tests/chrome/test_scriptSettings.xul
3: js/xpconnect/tests/chrome/test_windowProxyDeadWrapper.html

All of those three tests rely on the fact that data: URIs used to be same origin with the including context, which we are about to change. I think the best way to update those tests is to load information from a dummy file which is loaded from the same origin, agreed?
Attachment #8885603 - Flags: review?(bobbyholley)

Comment 2

11 months ago
Comment on attachment 8885603 [details] [diff] [review]
bug_1380249_update_tests_js_xpconnect.patch

Review of attachment 8885603 [details] [diff] [review]:
-----------------------------------------------------------------

Please make a copy of file_empty (which lives in the xpconnect mochitest dir) and use that instead of file_dummy, for consistency (you can remove the comment about other consumers for the chrome-copy, probably). r=me with that
Attachment #8885603 - Flags: review?(bobbyholley) → review+

Comment 3

11 months ago
Pushed by mozilla@christophkerschbaumer.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a26c718cf33
Convert tests within js/xpconnect to comply with new data: URI inheritance model. r=bholley

Comment 4

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5a26c718cf33
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
(Assignee)

Updated

11 months ago
See Also: → bug 1382815
You need to log in before you can comment on or make changes to this bug.