Trim the stack traces we send in the crash ping

VERIFIED FIXED in Firefox 57

Status

()

Toolkit
Crash Reporting
VERIFIED FIXED
4 months ago
2 months ago

People

(Reporter: gsvelto, Assigned: gsvelto)

Tracking

(Blocks: 2 bugs)

unspecified
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

4 months ago
We currently put all stack traces for all the threads and for each trace we send all the frames in every crash ping. Since we plan on using this only for creating signatures and thus getting more accurate statistics on crash frequency this is most certainly overkill. We could send the stack trace only for the crashing thread and possibly limit the number of frames we send.
(Assignee)

Updated

3 months ago
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Comment 2

3 months ago
mozreview-review
Comment on attachment 8898035 [details]
Bug 1380252 - Send only the crashing thread's stack in crash pings; .mielczarek

https://reviewboard.mozilla.org/r/169334/#review178708
Attachment #8898035 - Flags: review?(ted) → review+

Comment 3

3 months ago
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/022687c2669f
Send only the crashing thread's stack in crash pings; r=ted.mielczarek
https://hg.mozilla.org/mozilla-central/rev/022687c2669f
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
(Assignee)

Updated

2 months ago
Blocks: 1398830

Comment 5

2 months ago
We tested this on windows 10,7, Ubuntu 16.04 and OSX 10.12 with the latest Nightly and it is verified as fixed.
Test case and runs are here: https://public.etherpad-mozilla.org/p/1380252
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
You need to log in before you can comment on or make changes to this bug.