Closed Bug 1380252 Opened 2 years ago Closed 2 years ago

Trim the stack traces we send in the crash ping

Categories

(Toolkit :: Crash Reporting, enhancement)

enhancement
Not set

Tracking

()

VERIFIED FIXED
mozilla57
Tracking Status
firefox57 --- verified

People

(Reporter: gsvelto, Assigned: gsvelto)

References

Details

Attachments

(1 file)

We currently put all stack traces for all the threads and for each trace we send all the frames in every crash ping. Since we plan on using this only for creating signatures and thus getting more accurate statistics on crash frequency this is most certainly overkill. We could send the stack trace only for the crashing thread and possibly limit the number of frames we send.
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Comment on attachment 8898035 [details]
Bug 1380252 - Send only the crashing thread's stack in crash pings; .mielczarek

https://reviewboard.mozilla.org/r/169334/#review178708
Attachment #8898035 - Flags: review?(ted) → review+
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/022687c2669f
Send only the crashing thread's stack in crash pings; r=ted.mielczarek
https://hg.mozilla.org/mozilla-central/rev/022687c2669f
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Blocks: 1398830
We tested this on windows 10,7, Ubuntu 16.04 and OSX 10.12 with the latest Nightly and it is verified as fixed.
Test case and runs are here: https://public.etherpad-mozilla.org/p/1380252
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.