Remove the StackTraces field from the .extra file before submitting a crash report

VERIFIED FIXED in Firefox 57

Status

()

Toolkit
Crash Reporting
VERIFIED FIXED
4 months ago
2 months ago

People

(Reporter: gsvelto, Assigned: ccorcoran)

Tracking

(Blocks: 1 bug)

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 verified, firefox58 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

4 months ago
The minidump analyzer currently writes the resulting stack traces in a crash .extra's file so that they can be picked up by Gecko or the crash reporter client when assembling a crash ping. This data is redundant from Socorro's POV so there's no point in sending it in a crash report. We should either strip this field out of the .extra file before uploading it or changing the mechanism the minidump analyzer uses to return it so that it doesn't pollute the .extra file.
Assignee: nobody → ccorcoran
Comment hidden (mozreview-request)
(Reporter)

Updated

3 months ago
Status: NEW → ASSIGNED
(Reporter)

Comment 2

3 months ago
mozreview-review
Comment on attachment 8901821 [details]
bug 1380254: Don't send StackTraces field to Socorro;

https://reviewboard.mozilla.org/r/173214/#review178774

LGTM
Attachment #8901821 - Flags: review?(gsvelto) → review+
Keywords: checkin-needed

Comment 3

3 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6cd343de09d2
Don't send StackTraces field to Socorro; r=gsvelto
Keywords: checkin-needed

Comment 4

3 months ago
Pushed by kwierso@gmail.com:
https://hg.mozilla.org/mozilla-central/rev/76cf7d563120
Don't send StackTraces field to Socorro; r=gsvelto

Comment 5

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/76cf7d563120
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57

Comment 6

2 months ago
I have tested this on Ubuntu 16.04, OSX 10.11 and Windows 10 and 7 with the latest Nightly. Now, the StackTraces field is removed from .extra file before submitting a crash report, unlike it was before the fix.

Test cases and runs are here: https://public.etherpad-mozilla.org/p/1380254
Status: RESOLVED → VERIFIED
status-firefox57: fixed → verified
status-firefox58: --- → verified
You need to log in before you can comment on or make changes to this bug.