Remove the StackTraces field from the .extra file before submitting a crash report

VERIFIED FIXED in Firefox 57

Status

()

enhancement
VERIFIED FIXED
2 years ago
7 months ago

People

(Reporter: gsvelto, Assigned: ccorcoran)

Tracking

(Blocks 1 bug)

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 verified, firefox58 verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

2 years ago
The minidump analyzer currently writes the resulting stack traces in a crash .extra's file so that they can be picked up by Gecko or the crash reporter client when assembling a crash ping. This data is redundant from Socorro's POV so there's no point in sending it in a crash report. We should either strip this field out of the .extra file before uploading it or changing the mechanism the minidump analyzer uses to return it so that it doesn't pollute the .extra file.
(Assignee)

Updated

2 years ago
Assignee: nobody → ccorcoran
Comment hidden (mozreview-request)
(Reporter)

Updated

2 years ago
Status: NEW → ASSIGNED
(Reporter)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8901821 [details]
bug 1380254: Don't send StackTraces field to Socorro;

https://reviewboard.mozilla.org/r/173214/#review178774

LGTM
Attachment #8901821 - Flags: review?(gsvelto) → review+
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 3

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6cd343de09d2
Don't send StackTraces field to Socorro; r=gsvelto
Keywords: checkin-needed

Comment 4

2 years ago
Pushed by kwierso@gmail.com:
https://hg.mozilla.org/mozilla-central/rev/76cf7d563120
Don't send StackTraces field to Socorro; r=gsvelto

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/76cf7d563120
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
I have tested this on Ubuntu 16.04, OSX 10.11 and Windows 10 and 7 with the latest Nightly. Now, the StackTraces field is removed from .extra file before submitting a crash report, unlike it was before the fix.

Test cases and runs are here: https://public.etherpad-mozilla.org/p/1380254
Status: RESOLVED → VERIFIED
(Reporter)

Updated

7 months ago
See Also: → 1492815
You need to log in before you can comment on or make changes to this bug.