Closed
Bug 1380266
Opened 7 years ago
Closed 7 years ago
[Android O] Inconsistency at Back from Settings SubMenu
Categories
(Firefox for Android Graveyard :: Settings and Preferences, defect, P1)
Tracking
(fennec+, firefox55 wontfix, firefox56 verified, firefox57 verified)
VERIFIED
FIXED
Firefox 57
People
(Reporter: ioana.chiorean, Assigned: jwu)
References
Details
(Keywords: regression, Whiteboard: [FNC][SPT57.3][INT])
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
cnevinchen
:
review+
lizzard
:
approval-mozilla-beta-
lizzard
:
approval-mozilla-release+
|
Details |
Nexus 6P - Android O Steps: 1. Go to a submenu in Settings ( Settings -> Privacy fro ex) 2. Tap the back button from top left corner Expected results: - like on other Android versions - the back would go to the settings menu Actual results: - the back button returns you in the webpage previously loaded See video: https://youtu.be/Iy7apMTJcXI
Comment 2•7 years ago
|
||
Hi Joe, Wesly Please help me prioritize this. Thanks!
Comment 3•7 years ago
|
||
My 2 cents: Android O started shipping this week, and things like these just scream "lacks polish"...
Comment 6•7 years ago
|
||
I think :jwu is working on this. Please correct me if I'm wrong
Assignee: nobody → topwu.tw
tracking-fennec: ? → +
Assignee | ||
Comment 7•7 years ago
|
||
Looks like the behavior of HomeAsUpIndicator in Android O is changed, it doesn't pop up fragment from stack but directly leaves activity. One simple solution is to hook HomeAsUpIndicator's click listener to call `onBackPressed()` to make sure it has same behavior of Back button.
Comment hidden (mozreview-request) |
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8906442 [details] Bug 1380266 - Keep identical click behavior between HomeAsUpIndicator and back button. https://reviewboard.mozilla.org/r/178152/#review183450 This looks fine to me, but since I'm not familiar with code - and it's not clear to me why the previous behaviour actually functioned correctly - and so I'm not sure if this might introduce bugs on some API level. Clearing the flag, I'll rely on Nevin for his review.
Attachment #8906442 -
Flags: review?(gkruglov)
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8906442 [details] Bug 1380266 - Keep identical click behavior between HomeAsUpIndicator and back button. https://reviewboard.mozilla.org/r/178152/#review184112
Attachment #8906442 -
Flags: review?(cnevinchen) → review+
Comment 11•7 years ago
|
||
Pushed by nechen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2065eef5fa19 Keep identical click behavior between HomeAsUpIndicator and back button. r=nechen
Comment 12•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2065eef5fa19
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Comment 13•7 years ago
|
||
This grafts cleanly to 56. Please nominate this for release approval so we can get it into Monday's b13.
Assignee | ||
Comment 14•7 years ago
|
||
Comment on attachment 8906442 [details] Bug 1380266 - Keep identical click behavior between HomeAsUpIndicator and back button. Approval Request Comment [Feature/Bug causing the regression]: This issue is caused by new platform(Android O) behavior change. [User impact if declined]: Non-identical HomeAsUpIndicator navigation behavior between different platform versions. [Is this code covered by automated tests?]: No [Has the fix been verified in Nightly?]: Not yet. [Needs manual test from QE? If yes, steps to reproduce]: Yes, please check the STR in https://bugzilla.mozilla.org/show_bug.cgi?id=1380266#c0 [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No [Why is the change risky/not risky?]: This one-line change modifies the logic of menu's HomeAsUpIndicator in Android O to keep identical behavior between different platform versions. - The change is only limited in Android O and limited in the setting page. - The back button can always be regarded as a replacement if HomeAsUpIndicator is broken. [String changes made/needed]: No
Flags: needinfo?(topwu.tw)
Attachment #8906442 -
Flags: approval-mozilla-beta?
Comment 15•7 years ago
|
||
Hi Ioana: Would you help get this it verified in Nightly soon, hopefully before the next beta build? Thanks. (In reply to Jing-wei Wu [:jwu] from comment #14) > Comment on attachment 8906442 [details] > [Has the fix been verified in Nightly?]: > Not yet. > > [Needs manual test from QE? If yes, steps to reproduce]: > Yes, please check the STR in > https://bugzilla.mozilla.org/show_bug.cgi?id=1380266#c0 (In reply to Ryan VanderMeulen [:RyanVM] from comment #13) > This grafts cleanly to 56. Please nominate this for release approval so we > can get it into Monday's b13.
Flags: needinfo?(ioana.chiorean)
Reporter | ||
Comment 16•7 years ago
|
||
> Nexus 6P - Android O
> Steps:
> 1. Go to a submenu in Settings ( Settings -> Privacy fro ex)
> 2. Tap the back button from top left corner
Using the steps from the description I can not reproduce this anymore.
Flags: needinfo?(ioana.chiorean)
Comment 17•7 years ago
|
||
Comment on attachment 8906442 [details] Bug 1380266 - Keep identical click behavior between HomeAsUpIndicator and back button. For the fennec mobile build today (so the relbranch for 56)
Attachment #8906442 -
Flags: approval-mozilla-release+
Attachment #8906442 -
Flags: approval-mozilla-beta?
Attachment #8906442 -
Flags: approval-mozilla-beta-
Comment 18•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/59958378c2ce (FIREFOX_56b13_RELBRANCH) https://hg.mozilla.org/releases/mozilla-release/rev/80c1e4794e11
Comment 19•7 years ago
|
||
Verified as fix on the latest beta build 56.0b13. This issue was verified on a Nexus 6P (Android 8.0)
Updated•7 years ago
|
Whiteboard: [FNC][SPT57.3][INT]
Updated•6 years ago
|
Status: RESOLVED → VERIFIED
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•