Let the new search textbox styling graduate from in-content/common.inc.css to textbox.css

VERIFIED FIXED in Firefox 56

Status

()

Toolkit
Themes
P1
normal
VERIFIED FIXED
a month ago
8 days ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed, firefox57 verified)

Details

(Whiteboard: [photon-visual][p2])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a month ago
With bug 1378330 fixed, I think this is now ready to be used for all search textboxes.
(Assignee)

Updated

a month ago
Priority: -- → P1
(Assignee)

Updated

a month ago
Flags: qe-verify+
Comment hidden (mozreview-request)

Updated

a month ago
Iteration: --- → 56.3 - Jul 24
QA Contact: brindusa.tot

Comment 2

a month ago
mozreview-review
Comment on attachment 8885633 [details]
Bug 1380268 - Let the new search textbox styling graduate from in-content/common.inc.css to textbox.css.

https://reviewboard.mozilla.org/r/156488/#review162708
Attachment #8885633 - Flags: review?(nhnt11) → review+

Comment 3

a month ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dd4e52e83896
Let the new search textbox styling graduate from in-content/common.inc.css to textbox.css. r=nhnt11
(Assignee)

Comment 4

a month ago
Hmm, this will probably bounce. I forgot to update browser/themes/windows/syncedtabs/sidebar.css (it uses Search-glass.png).
Indeed. Backed out:

https://hg.mozilla.org/integration/autoland/rev/402045639196a2ed415b42b616cf2c1170005abc

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=dd4e52e83896d64b66adc8a303a2b49cec93d880&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Flags: needinfo?(dao+bmo)
Comment hidden (mozreview-request)

Comment 7

a month ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bccbac6fcf20
Let the new search textbox styling graduate from in-content/common.inc.css to textbox.css. r=nhnt11

Comment 8

a month ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/bccbac6fcf20
Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
(Assignee)

Updated

a month ago
Flags: needinfo?(dao+bmo)

Comment 9

15 days ago
Hi Nihanth,

Can you please advise me how to verify this issue? Thanks
Flags: needinfo?(nhnt11)
(Assignee)

Comment 10

15 days ago
(In reply to ovidiu boca[:Ovidiu] from comment #9)
> Hi Nihanth,
> 
> Can you please advise me how to verify this issue? Thanks

Check that our various search textboxes look consistent across platforms (including High Contrast mode on Windows). Search textboxes to check:

- History and bookmarks sidebars
- about:preferences
- about:config
- about:addons
Flags: needinfo?(nhnt11)
Thanks Dão for your suggestions. I tested on Mac OS X 10.12 Windows 10 and Ubuntu 16.04 with Nightly 57.0a1(2017-08-08) and the various search text boxes look consistent except 2 cases: 

On Ubuntu 16.04 the border line from search field from bookmarks or history sidebars has an orange color(like the one from URL bar or search bar), the border line from search field from about:preferences, about:config, about:addons, has a blue color.
 
Also On Win 10 with High Contrast mode, there is a difference between border line color (search text boxes) from history or bookmarks sidebars and about pages.
This is intended?
Flags: needinfo?(dao+bmo)
(Assignee)

Comment 12

15 days ago
(In reply to ovidiu boca[:Ovidiu] from comment #11)
> On Ubuntu 16.04 the border line from search field from bookmarks or history
> sidebars has an orange color(like the one from URL bar or search bar), the
> border line from search field from about:preferences, about:config,
> about:addons, has a blue color.
>  
> Also On Win 10 with High Contrast mode, there is a difference between border
> line color (search text boxes) from history or bookmarks sidebars and about
> pages.

This is an unfortunate inconsistency but expected for the time being.
Flags: needinfo?(dao+bmo)
Thanks Dão,

Based on comment 11 and comment 12, I will mark this as a verified fix.
Status: RESOLVED → VERIFIED
status-firefox57: --- → verified
Flags: qe-verify+

Updated

8 days ago
Depends on: 1390586
You need to log in before you can comment on or make changes to this bug.