1380268 - Let the new search textbox styling graduate from in-content/common.inc.css to textbox.css

Status: VERIFIED FIXED

(Toolkit :: Themes, defect, P1)

Description

[Dão Gottwald [::dao]]

With bug 1378330 fixed, I think this is now ready to be used for all search textboxes.

Comment 1

[Dão Gottwald [::dao]]

Attachment: Bug 1380268 - Let the new search textbox styling graduate from in-content/common.inc.css to textbox.css.

Review commit: https://reviewboard.mozilla.org/r/156488/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156488/

Comment 2

[Nihanth Subramanya [:nhnt11]]

Comment on attachment 8885633 [details]
Bug 1380268 - Let the new search textbox styling graduate from in-content/common.inc.css to textbox.css.

https://reviewboard.mozilla.org/r/156488/#review162708

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dd4e52e83896
Let the new search textbox styling graduate from in-content/common.inc.css to textbox.css. r=nhnt11

Comment 4

[Dão Gottwald [::dao]]

Hmm, this will probably bounce. I forgot to update browser/themes/windows/syncedtabs/sidebar.css (it uses Search-glass.png).

Comment 5

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

Indeed. Backed out:

https://hg.mozilla.org/integration/autoland/rev/402045639196a2ed415b42b616cf2c1170005abc

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=dd4e52e83896d64b66adc8a303a2b49cec93d880&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable

Comment 6

[Dão Gottwald [::dao]]

Comment on attachment 8885633 [details]
Bug 1380268 - Let the new search textbox styling graduate from in-content/common.inc.css to textbox.css.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/156488/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bccbac6fcf20
Let the new search textbox styling graduate from in-content/common.inc.css to textbox.css. r=nhnt11

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bccbac6fcf20

Comment 9

[ovidiu boca[:Ovidiu]]

Hi Nihanth,

Can you please advise me how to verify this issue? Thanks

Comment 10

[Dão Gottwald [::dao]]

(In reply to ovidiu boca[:Ovidiu] from comment #9)
> Hi Nihanth,
> 
> Can you please advise me how to verify this issue? Thanks

Check that our various search textboxes look consistent across platforms (including High Contrast mode on Windows). Search textboxes to check:

- History and bookmarks sidebars
- about:preferences
- about:config
- about:addons

Comment 11

[ovidiu boca[:Ovidiu]]

Thanks Dão for your suggestions. I tested on Mac OS X 10.12 Windows 10 and Ubuntu 16.04 with Nightly 57.0a1(2017-08-08) and the various search text boxes look consistent except 2 cases: 

On Ubuntu 16.04 the border line from search field from bookmarks or history sidebars has an orange color(like the one from URL bar or search bar), the border line from search field from about:preferences, about:config, about:addons, has a blue color.
 
Also On Win 10 with High Contrast mode, there is a difference between border line color (search text boxes) from history or bookmarks sidebars and about pages.
This is intended?

Comment 12

[Dão Gottwald [::dao]]

(In reply to ovidiu boca[:Ovidiu] from comment #11)
> On Ubuntu 16.04 the border line from search field from bookmarks or history
> sidebars has an orange color(like the one from URL bar or search bar), the
> border line from search field from about:preferences, about:config,
> about:addons, has a blue color.
>  
> Also On Win 10 with High Contrast mode, there is a difference between border
> line color (search text boxes) from history or bookmarks sidebars and about
> pages.

This is an unfortunate inconsistency but expected for the time being.

Comment 13

[ovidiu boca[:Ovidiu]]

Thanks Dão,

Based on comment 11 and comment 12, I will mark this as a verified fix.