Closed Bug 1380268 Opened 2 years ago Closed 2 years ago

Let the new search textbox styling graduate from in-content/common.inc.css to textbox.css

Categories

(Toolkit :: Themes, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla56
Iteration:
56.3 - Jul 24
Tracking Status
firefox56 --- fixed
firefox57 --- verified

People

(Reporter: dao, Assigned: dao)

References

Details

(Whiteboard: [photon-visual][p2])

Attachments

(1 file)

With bug 1378330 fixed, I think this is now ready to be used for all search textboxes.
Priority: -- → P1
Flags: qe-verify+
Iteration: --- → 56.3 - Jul 24
QA Contact: brindusa.tot
Comment on attachment 8885633 [details]
Bug 1380268 - Let the new search textbox styling graduate from in-content/common.inc.css to textbox.css.

https://reviewboard.mozilla.org/r/156488/#review162708
Attachment #8885633 - Flags: review?(nhnt11) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dd4e52e83896
Let the new search textbox styling graduate from in-content/common.inc.css to textbox.css. r=nhnt11
Hmm, this will probably bounce. I forgot to update browser/themes/windows/syncedtabs/sidebar.css (it uses Search-glass.png).
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bccbac6fcf20
Let the new search textbox styling graduate from in-content/common.inc.css to textbox.css. r=nhnt11
https://hg.mozilla.org/mozilla-central/rev/bccbac6fcf20
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Flags: needinfo?(dao+bmo)
Hi Nihanth,

Can you please advise me how to verify this issue? Thanks
Flags: needinfo?(nhnt11)
(In reply to ovidiu boca[:Ovidiu] from comment #9)
> Hi Nihanth,
> 
> Can you please advise me how to verify this issue? Thanks

Check that our various search textboxes look consistent across platforms (including High Contrast mode on Windows). Search textboxes to check:

- History and bookmarks sidebars
- about:preferences
- about:config
- about:addons
Flags: needinfo?(nhnt11)
Thanks Dão for your suggestions. I tested on Mac OS X 10.12 Windows 10 and Ubuntu 16.04 with Nightly 57.0a1(2017-08-08) and the various search text boxes look consistent except 2 cases: 

On Ubuntu 16.04 the border line from search field from bookmarks or history sidebars has an orange color(like the one from URL bar or search bar), the border line from search field from about:preferences, about:config, about:addons, has a blue color.
 
Also On Win 10 with High Contrast mode, there is a difference between border line color (search text boxes) from history or bookmarks sidebars and about pages.
This is intended?
Flags: needinfo?(dao+bmo)
(In reply to ovidiu boca[:Ovidiu] from comment #11)
> On Ubuntu 16.04 the border line from search field from bookmarks or history
> sidebars has an orange color(like the one from URL bar or search bar), the
> border line from search field from about:preferences, about:config,
> about:addons, has a blue color.
>  
> Also On Win 10 with High Contrast mode, there is a difference between border
> line color (search text boxes) from history or bookmarks sidebars and about
> pages.

This is an unfortunate inconsistency but expected for the time being.
Flags: needinfo?(dao+bmo)
Thanks Dão,

Based on comment 11 and comment 12, I will mark this as a verified fix.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Depends on: 1390586
Depends on: 1400615
No longer depends on: 1396278
You need to log in before you can comment on or make changes to this bug.