1380282 - rewrite browser/components/extensions/test/browser/browser_ext_webRequest.js

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P2)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

browser/components/extensions/test/browser/browser_ext_webRequest.js failed when we enable data: URI is unique opaque origin.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch

Hi Kmag, 
I git blame it and found you reviewed the test before, can you help to review this change?

Thanks

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8885657 [details] [diff] [review]
Patch

Review of attachment 8885657 [details] [diff] [review]:
-----------------------------------------------------------------

It looks kmag is busy and didn't review it in the past week,
change the r? to mixedpuppy.

Comment 3

[Kris Maglione [:kmag]]

Comment on attachment 8885657 [details] [diff] [review]
Patch

Review of attachment 8885657 [details] [diff] [review]:
-----------------------------------------------------------------

This commit description doesn't seem very accurate.

Also, I suspect there are other places where we'll need to change this, in particular:

http://searchfox.org/mozilla-central/rev/88180977d79654af025158d8ebeb8c2aa11940eb/toolkit/components/extensions/ExtensionXPCShellUtils.jsm#65-67
http://searchfox.org/mozilla-central/rev/88180977d79654af025158d8ebeb8c2aa11940eb/addon-sdk/source/lib/sdk/addon/window.js#64

And it would be nice if we didn't need a separate document for:

http://searchfox.org/mozilla-central/rev/88180977d79654af025158d8ebeb8c2aa11940eb/toolkit/components/extensions/ExtensionParent.jsm#858

Comment 4

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

(In reply to Kris Maglione [:kmag] from comment #3)
> 
> Also, I suspect there are other places where we'll need to change this, in
> particular:
> 
> http://searchfox.org/mozilla-central/rev/
> 88180977d79654af025158d8ebeb8c2aa11940eb/toolkit/components/extensions/
> ExtensionXPCShellUtils.jsm#65-67
Fixed in Bug 1381769

> http://searchfox.org/mozilla-central/rev/
> 88180977d79654af025158d8ebeb8c2aa11940eb/addon-sdk/source/lib/sdk/addon/
> window.js#64
> 
I'll look into this one, thanks

> And it would be nice if we didn't need a separate document for:
> 
> http://searchfox.org/mozilla-central/rev/
> 88180977d79654af025158d8ebeb8c2aa11940eb/toolkit/components/extensions/
> ExtensionParent.jsm#858
Do you have any better suggestion?
smaug suggested me to use a seperate document for this.

Thanks for your revieww.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch v2.

updated commit message.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9dc2a03c3574
rewrite browser_ext_webRequest.js for the new data: URI inheritance model. r=kmag

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9dc2a03c3574