Closed Bug 1380282 Opened 2 years ago Closed 2 years ago

rewrite browser/components/extensions/test/browser/browser_ext_webRequest.js

Categories

(Core :: DOM: Security, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: allstars.chh, Assigned: allstars.chh)

References

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 file, 1 obsolete file)

browser/components/extensions/test/browser/browser_ext_webRequest.js failed when we enable data: URI is unique opaque origin.
Attached patch Patch (obsolete) — Splinter Review
Hi Kmag, 
I git blame it and found you reviewed the test before, can you help to review this change?

Thanks
Attachment #8885657 - Flags: review?(kmaglione+bmo)
Status: NEW → ASSIGNED
Comment on attachment 8885657 [details] [diff] [review]
Patch

Review of attachment 8885657 [details] [diff] [review]:
-----------------------------------------------------------------

It looks kmag is busy and didn't review it in the past week,
change the r? to mixedpuppy.
Attachment #8885657 - Flags: review?(mixedpuppy)
Comment on attachment 8885657 [details] [diff] [review]
Patch

Review of attachment 8885657 [details] [diff] [review]:
-----------------------------------------------------------------

This commit description doesn't seem very accurate.

Also, I suspect there are other places where we'll need to change this, in particular:

http://searchfox.org/mozilla-central/rev/88180977d79654af025158d8ebeb8c2aa11940eb/toolkit/components/extensions/ExtensionXPCShellUtils.jsm#65-67
http://searchfox.org/mozilla-central/rev/88180977d79654af025158d8ebeb8c2aa11940eb/addon-sdk/source/lib/sdk/addon/window.js#64

And it would be nice if we didn't need a separate document for:

http://searchfox.org/mozilla-central/rev/88180977d79654af025158d8ebeb8c2aa11940eb/toolkit/components/extensions/ExtensionParent.jsm#858
Attachment #8885657 - Flags: review?(mixedpuppy)
Attachment #8885657 - Flags: review?(kmaglione+bmo)
Attachment #8885657 - Flags: review+
(In reply to Kris Maglione [:kmag] from comment #3)
> 
> Also, I suspect there are other places where we'll need to change this, in
> particular:
> 
> http://searchfox.org/mozilla-central/rev/
> 88180977d79654af025158d8ebeb8c2aa11940eb/toolkit/components/extensions/
> ExtensionXPCShellUtils.jsm#65-67
Fixed in Bug 1381769

> http://searchfox.org/mozilla-central/rev/
> 88180977d79654af025158d8ebeb8c2aa11940eb/addon-sdk/source/lib/sdk/addon/
> window.js#64
> 
I'll look into this one, thanks

> And it would be nice if we didn't need a separate document for:
> 
> http://searchfox.org/mozilla-central/rev/
> 88180977d79654af025158d8ebeb8c2aa11940eb/toolkit/components/extensions/
> ExtensionParent.jsm#858
Do you have any better suggestion?
smaug suggested me to use a seperate document for this.

Thanks for your revieww.
Attached patch Patch v2.Splinter Review
updated commit message.
Attachment #8885657 - Attachment is obsolete: true
Attachment #8887805 - Flags: review+
Pushed by yhuang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9dc2a03c3574
rewrite browser_ext_webRequest.js for the new data: URI inheritance model. r=kmag
https://hg.mozilla.org/mozilla-central/rev/9dc2a03c3574
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.