1380294 - [Firefox Notes] Formatting option tooltips are wrongly displayed on the latest Nightly

Status: VERIFIED FIXED

(WebExtensions :: General, defect, P1)

Description

[Emil Pasca [:emilpasca]]

Attachment: tooltips_nightly.gif

[Affected versions]:
- Nightly 56.0a1, Build ID: 20170711030203

[Affected Platforms]:
- All Windows

[Prerequisites]:
- Have a Firefox profile with the latest Notes add-on (version 1.5-dev) installed.

[Steps to reproduce]:
1. Open the browser with the profile from prerequisites.
2. Hover the formatting option buttons("Bold","Italic","Ordered list", etc.) from "Notes" sidebar.
3. Observe the displayed tooltips.

[Expected result]:
- The tooltips are displayed correctly below the corresponding buttons.

[Actual result]:
- The tooltips appear very far to the right of the button.

[Regression]:
With Nightly 56.0a1, Build ID: 20170710030203, the issue is not reproducible.
Last good revision: 392ed89ec2730a48d10b1cec741e86a242d28aa3
First bad revision: a625a2e9b3333a8e76982ea65f077cfded6ac224
Pushlog: https://goo.gl/N1DhXR

[Notes]:
- Attached a screen recording of the issue.

Refs https://github.com/mozilla/notes/issues/136

Kris, can you please have a look at this?

Comment 1

[Andy McKay]

Sounds like might be related to oop.

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Fixed in the duplicate.

Comment 4

[Liz Henry (:lizzard) (relman/hg->git project)]

On 2nd look, it may not have been fixed in bug 1379508. I've reopened that bug.

Comment 5

[CosminB]

Attachment: TooltipIssue.gif

This issue is still reproducing, checked on Firefox 56.0a1 (2017-07-24) under Win 7 64-bit and Ubuntu Ubuntu 16.04 LTS 32-bit.

Please see the attached video.

Comment 8

[Andy McKay]

Is there a build of this somewhere as an xpi that we can test?

Comment 9

[Andy McKay]

I grabbed a build from https://github.com/mozilla/notes/releases. No tooltips were showing up, so I changed a button to <button class="ql-bold" title="Bold"></button> and the same problem seems to be reproducing - the tooltip appears way over on the right. It does not reproduce with oop turned off.

Comment 10

[Kris Maglione [:kmag]]

Attachment: Bug 1380294: Anchor non-tab tooltips to the correct remote browser.

Review commit: https://reviewboard.mozilla.org/r/163644/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163644/

Comment 11

[Andrew Swan [:aswan]]

Comment on attachment 8892657 [details]
Bug 1380294: Anchor non-tab tooltips to the correct remote browser.

https://reviewboard.mozilla.org/r/163644/#review169038

Comment 12

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3afb9a45faebc2e32591f881943fabae4f84b19a
Bug 1380294: Anchor non-tab tooltips to the correct remote browser. r=aswan

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/3afb9a45faeb

Comment 14

[Kris Maglione [:kmag]]

Comment on attachment 8892657 [details]
Bug 1380294: Anchor non-tab tooltips to the correct remote browser.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1357486
[User impact if declined]: This causes confusing and unexpected UI behavior for tooltips in several extension UI elements.
[Is this code covered by automated tests?]: For tooltips in general, yes, but not yet for the positioning of tooltips in the particular places that this bug addresses.
[Has the fix been verified in Nightly?]: No.
[Needs manual test from QE? If yes, steps to reproduce]: STR are listed in previous comments.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: Low-risk.
[Why is the change risky/not risky?]: This change is very simple, and confined to the placement of OOP tooltips. The worst case regression would be tooltips not showing up.
[String changes made/needed]: None.

Comment 15

[Gerry Chang [:gchang]]

Hi Emil, could you help verify if this issue was fixed as expected on the latest Nightly build? Thanks.

Comment 16

[Emil Pasca [:emilpasca]]

I can confirm that the issue is no longer reproducible on Windows 7 x64 and Windows 10 x64 with the latest Nightly 57.0a1 build ID: 20170808114032.

Comment 17

[Gerry Chang [:gchang]]

Comment on attachment 8892657 [details]
Bug 1380294: Anchor non-tab tooltips to the correct remote browser.

Fix a regression and was verified. Beta56+. Should be in 56 beta 2.

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c3e9ce491b38

Comment 19

[Emil Pasca [:emilpasca]]

I can confirm that the issue is no longer reproducible on Windows 10 x64 with the latest Beta 56.0b2 build ID: 20170810180547.