1380302 - Fix -Wmaybe-uninitialized warnings in Places

Status: RESOLVED FIXED

(Toolkit :: Places, defect, P1)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

[task 2017-07-11T14:04:21.192280Z] 14:04:21     INFO -  warning: toolkit/components/places/nsNavBookmarks.cpp:102:7 [-Wmaybe-uninitialized] 'tagsFolderId' may be used uninitialized in this function
[task 2017-07-11T14:04:21.192414Z] 14:04:21     INFO -  warning: toolkit/components/places/nsNavBookmarks.cpp:562:3 [-Wmaybe-uninitialized] 'tagsRootId' may be used uninitialized in this function
[task 2017-07-11T14:04:21.192531Z] 14:04:21     INFO -  warning: toolkit/components/places/nsNavBookmarks.cpp:674:3 [-Wmaybe-uninitialized] 'tagsRootId' may be used uninitialized in this function
[task 2017-07-11T14:04:21.192691Z] 14:04:21     INFO -  warning: toolkit/components/places/nsNavBookmarks.cpp:796:72 [-Wmaybe-uninitialized] 'tagsRootId' may be used uninitialized in this function
[task 2017-07-11T14:04:21.192798Z] 14:04:21     INFO -  warning: toolkit/components/places/nsNavBookmarks.cpp:1331:37 [-Wmaybe-uninitialized] 'tagsRootId' may be used uninitialized in this function
[task 2017-07-11T14:04:21.192927Z] 14:04:21     INFO -  warning: toolkit/components/places/nsNavBookmarks.cpp:1515:3 [-Wmaybe-uninitialized] 'tagsRootId' may be used uninitialized in this function
[task 2017-07-11T14:04:21.193087Z] 14:04:21     INFO -  warning: toolkit/components/places/nsNavBookmarks.cpp:1678:3 [-Wmaybe-uninitialized] 'tagsRootId' may be used uninitialized in this function
[task 2017-07-11T14:04:21.193203Z] 14:04:21     INFO -  warning: toolkit/components/places/nsNavBookmarks.cpp:1751:3 [-Wmaybe-uninitialized] 'tagsRootId' may be used uninitialized in this function
[task 2017-07-11T14:04:21.193353Z] 14:04:21     INFO -  warning: toolkit/components/places/nsNavBookmarks.cpp:2017:51 [-Wmaybe-uninitialized] 'tagsRootId' may be used uninitialized in this function
[task 2017-07-11T14:04:21.193471Z] 14:04:21     INFO -  warning: toolkit/components/places/nsNavBookmarks.cpp:2561:3 [-Wmaybe-uninitialized] 'tagsRootId' may be used uninitialized in this function
[task 2017-07-11T14:04:21.193615Z] 14:04:21     INFO -  warning: toolkit/components/places/nsNavBookmarks.cpp:2646:74 [-Wmaybe-uninitialized] 'tagsRootId' may be used uninitialized in this function
[task 2017-07-11T14:04:21.193756Z] 14:04:21     INFO -  warning: toolkit/components/places/nsNavBookmarks.cpp:2695:5 [-Wmaybe-uninitialized] 'tagsRootId' may be used uninitialized in this function
[task 2017-07-11T14:04:21.193874Z] 14:04:21     INFO -  warning: toolkit/components/places/nsNavHistoryQuery.cpp:213:52 [-Wmaybe-uninitialized] 'folderID' may be used uninitialized in this function
[task 2017-07-11T14:04:21.194025Z] 14:04:21     INFO -  warning: toolkit/components/places/nsNavHistoryQuery.cpp:1607:35 [-Wmaybe-uninitialized] 'value' may be used uninitialized in this function
[task 2017-07-11T14:04:21.194155Z] 14:04:21     INFO -  warning: toolkit/components/places/nsPlacesMacros.h:39:21 [-Wmaybe-uninitialized] 'tagsRootId' may be used uninitialized in this function

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: Bug 1380302 - Fix -Wmaybe-uninitialized warnings in Places.

Review commit: https://reviewboard.mozilla.org/r/156646/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156646/

Comment 2

[Drew Willcoxon :adw]

Comment on attachment 8885876 [details]
Bug 1380302 - Fix -Wmaybe-uninitialized warnings in Places.

https://reviewboard.mozilla.org/r/156646/#review161838

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a859e2a0ae06
Fix -Wmaybe-uninitialized warnings in Places. r=adw

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a859e2a0ae06