Closed Bug 1380302 Opened 4 years ago Closed 4 years ago

Fix -Wmaybe-uninitialized warnings in Places

Categories

(Toolkit :: Places, defect, P1)

55 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: mak, Assigned: mak)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

[task 2017-07-11T14:04:21.192280Z] 14:04:21     INFO -  warning: toolkit/components/places/nsNavBookmarks.cpp:102:7 [-Wmaybe-uninitialized] 'tagsFolderId' may be used uninitialized in this function
[task 2017-07-11T14:04:21.192414Z] 14:04:21     INFO -  warning: toolkit/components/places/nsNavBookmarks.cpp:562:3 [-Wmaybe-uninitialized] 'tagsRootId' may be used uninitialized in this function
[task 2017-07-11T14:04:21.192531Z] 14:04:21     INFO -  warning: toolkit/components/places/nsNavBookmarks.cpp:674:3 [-Wmaybe-uninitialized] 'tagsRootId' may be used uninitialized in this function
[task 2017-07-11T14:04:21.192691Z] 14:04:21     INFO -  warning: toolkit/components/places/nsNavBookmarks.cpp:796:72 [-Wmaybe-uninitialized] 'tagsRootId' may be used uninitialized in this function
[task 2017-07-11T14:04:21.192798Z] 14:04:21     INFO -  warning: toolkit/components/places/nsNavBookmarks.cpp:1331:37 [-Wmaybe-uninitialized] 'tagsRootId' may be used uninitialized in this function
[task 2017-07-11T14:04:21.192927Z] 14:04:21     INFO -  warning: toolkit/components/places/nsNavBookmarks.cpp:1515:3 [-Wmaybe-uninitialized] 'tagsRootId' may be used uninitialized in this function
[task 2017-07-11T14:04:21.193087Z] 14:04:21     INFO -  warning: toolkit/components/places/nsNavBookmarks.cpp:1678:3 [-Wmaybe-uninitialized] 'tagsRootId' may be used uninitialized in this function
[task 2017-07-11T14:04:21.193203Z] 14:04:21     INFO -  warning: toolkit/components/places/nsNavBookmarks.cpp:1751:3 [-Wmaybe-uninitialized] 'tagsRootId' may be used uninitialized in this function
[task 2017-07-11T14:04:21.193353Z] 14:04:21     INFO -  warning: toolkit/components/places/nsNavBookmarks.cpp:2017:51 [-Wmaybe-uninitialized] 'tagsRootId' may be used uninitialized in this function
[task 2017-07-11T14:04:21.193471Z] 14:04:21     INFO -  warning: toolkit/components/places/nsNavBookmarks.cpp:2561:3 [-Wmaybe-uninitialized] 'tagsRootId' may be used uninitialized in this function
[task 2017-07-11T14:04:21.193615Z] 14:04:21     INFO -  warning: toolkit/components/places/nsNavBookmarks.cpp:2646:74 [-Wmaybe-uninitialized] 'tagsRootId' may be used uninitialized in this function
[task 2017-07-11T14:04:21.193756Z] 14:04:21     INFO -  warning: toolkit/components/places/nsNavBookmarks.cpp:2695:5 [-Wmaybe-uninitialized] 'tagsRootId' may be used uninitialized in this function
[task 2017-07-11T14:04:21.193874Z] 14:04:21     INFO -  warning: toolkit/components/places/nsNavHistoryQuery.cpp:213:52 [-Wmaybe-uninitialized] 'folderID' may be used uninitialized in this function
[task 2017-07-11T14:04:21.194025Z] 14:04:21     INFO -  warning: toolkit/components/places/nsNavHistoryQuery.cpp:1607:35 [-Wmaybe-uninitialized] 'value' may be used uninitialized in this function
[task 2017-07-11T14:04:21.194155Z] 14:04:21     INFO -  warning: toolkit/components/places/nsPlacesMacros.h:39:21 [-Wmaybe-uninitialized] 'tagsRootId' may be used uninitialized in this function
Priority: -- → P1
Whiteboard: [fxsearch]
Comment on attachment 8885876 [details]
Bug 1380302 - Fix -Wmaybe-uninitialized warnings in Places.

https://reviewboard.mozilla.org/r/156646/#review161838
Attachment #8885876 - Flags: review?(adw) → review+
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/a859e2a0ae06
Fix -Wmaybe-uninitialized warnings in Places. r=adw
https://hg.mozilla.org/mozilla-central/rev/a859e2a0ae06
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.