Closed Bug 1380375 Opened 7 years ago Closed 7 years ago

Free up element bit used by scrollgrab

Categories

(Core :: DOM: Core & HTML, enhancement)

Product:
Core
Component:
DOM: Core & HTML
Version:
Other Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

Patch
5.59 KB, patch
smaug
: review+
Details | Diff | Splinter Review 
Now that B2G is gone there's no code in tree that actually modifies the scrollgrab flag on Element. We can remove some of this code and free up the flag for other purposes.
Assignee: nobody → bugmail
(I'm working on the patch for this. It's good free up the bit even if we don't use it for keyboard scrolling in bug 1379280).
Attached patch Patch — — Splinter Review 

        Attachment #8885841 -
        Flags: review?(bugs)

    
    

    
  
Comment on attachment 8885841 [details] [diff] [review]
Patch

> 
>-  // Set if this element is marked as 'scrollgrab' (see bug 912666)
>-  ELEMENT_HAS_SCROLLGRAB = ELEMENT_FLAG_BIT(5),
>-
>   // Remaining bits are for subclasses
>   ELEMENT_TYPE_SPECIFIC_BITS_OFFSET = NODE_TYPE_SPECIFIC_BITS_OFFSET + 6

Not sure whether we want to move the extra bit to nsINode or whether we should have 
ELEMENT_TYPE_SPECIFIC_BITS_OFFSET = NODE_TYPE_SPECIFIC_BITS_OFFSET + 5.

But at least add a comment in place of ELEMENT_HAS_SCROLLGRAB that bit 5 is unused.

        Attachment #8885841 -
        Flags: review?(bugs) → review+

    
    

    
  
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/61c6ddbcf8a9
Remove the DOM bindings for the unused scrollgrab feature. r=smaug

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/61c6ddbcf8a9
Status: NEW → RESOLVED
Closed: 7 years ago

          status-firefox56:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Component: DOM → DOM: Core & HTML

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: