1380402 - Mac TPS build fails many tests

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement)

Description

[Thom Chiovoloni [:tcsc] (ex-moco)]

Noticed this yesterday when helping eoger test 1210296. Many tabs crash on mac which causes various TPS failures.

It's is because of bug 1379784. It's easy to fix since TPS can make a pretty accurate guess as to the source root, given that we have the TPS installation directory and TPS already requires a full source checkout in practice.

In the long term it would probably be better to make TPS use mach's code somehow, but that seems very much outside the scope of this bug. 

This is a small patch, but is a change to the TPS python code, and will require updating your TPS virtual env.

Comment 1

[Thom Chiovoloni [:tcsc] (ex-moco)]

Attachment: Bug 1380402 - Set MOZ_DEVELOPER_REPO_DIR in the environment when running TPS on mac.

Review commit: https://reviewboard.mozilla.org/r/156606/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/156606/

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8885828 [details]
Bug 1380402 - Set MOZ_DEVELOPER_REPO_DIR in the environment when running TPS on mac.

https://reviewboard.mozilla.org/r/156606/#review161870

rs=me, thanks

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/77f4c7873ce3
Set MOZ_DEVELOPER_REPO_DIR in the environment when running TPS on mac. r=markh

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/77f4c7873ce3