Closed Bug 1380402 Opened 6 years ago Closed 6 years ago

Mac TPS build fails many tests

Categories

(Firefox :: Sync, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed

People

(Reporter: tcsc, Assigned: tcsc)

References

Details

Attachments

(1 file)

Noticed this yesterday when helping eoger test 1210296. Many tabs crash on mac which causes various TPS failures.

It's is because of bug 1379784. It's easy to fix since TPS can make a pretty accurate guess as to the source root, given that we have the TPS installation directory and TPS already requires a full source checkout in practice.

In the long term it would probably be better to make TPS use mach's code somehow, but that seems very much outside the scope of this bug. 

This is a small patch, but is a change to the TPS python code, and will require updating your TPS virtual env.
Comment on attachment 8885828 [details]
Bug 1380402 - Set MOZ_DEVELOPER_REPO_DIR in the environment when running TPS on mac.

https://reviewboard.mozilla.org/r/156606/#review161870

rs=me, thanks
Attachment #8885828 - Flags: review?(markh) → review+
Pushed by tchiovoloni@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/77f4c7873ce3
Set MOZ_DEVELOPER_REPO_DIR in the environment when running TPS on mac. r=markh
https://hg.mozilla.org/mozilla-central/rev/77f4c7873ce3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.