Closed Bug 1380407 Opened 3 years ago Closed 3 years ago

Make elasticsearch ircnick checks consider numbers to be valid too

Categories

(bugzilla.mozilla.org :: General, enhancement)

Production
enhancement
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: dylan, Assigned: dylan)

Details

Attachments

(1 file)

PR
45 bytes, text/x-github-pull-request
seban
: review+
Details | Review
Right now, elasticsearch-powered user completion ignores numbers (or considers them stopwords, perhaps). This isn't really a great thing and should be fixed.
Attached file PR
Attachment #8886026 - Flags: review?(sebastinssanty)
You're probably wondering:

"Dylan, what the hell does this mean?"

Well, it seems that :k17 would match :k88 because we were using the simple analyzer, which in turn uses the standard tokenizer..

We want to be using the 'keyword' tokenizer which will do verbatim tokenization.
To do this, I added an analyzer named 'autocomplete' that uses this tokenizer.

https://www.elastic.co/guide/en/elasticsearch/reference/current/analysis-keyword-tokenizer.html
Attachment #8886026 - Flags: review?(sebastinssanty) → review+
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.