Closed
Bug 1380431
Opened 7 years ago
Closed 7 years ago
DrawTargetCairo::Snapshot crash in gfxCriticalNote message
Categories
(Core :: Graphics, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla56
People
(Reporter: lsalzman, Assigned: lsalzman)
References
Details
(Keywords: crash, regression, Whiteboard: [gfx-noted])
Crash Data
User Story
See this crash report: https://crash-stats.mozilla.com/report/index/deb6bdf5-81e3-4609-a983-e07ed0170706 Inside DrawTargetCairo::Snapshot(), when we're doing the gfxCriticalNote message, the mSurface is null, so when cairo_surface_status tries to access it, it goes kaboom. We need to check if it is null or not before we do that to prevent this.
Attachments
(1 file)
|
1.19 KB,
patch
|
mchang
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8885853 -
Flags: review?(mchang)
|
||
Updated•7 years ago
|
Attachment #8885853 -
Flags: review?(mchang) → review+
Pushed by lsalzman@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bf8fee7089b4 fix DrawTargetCairo::Snapshot error note to check for surface before accessing status. r=mchang
|
||
Comment 2•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/bf8fee7089b4
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
|
||
Comment 3•7 years ago
|
||
Doesn't look frequent enough to warrant backport consideration, but feel free to change the status back to affected and nominate for approval if you feel otherwise.
Crash Signature: [@ mozilla::gfx::DrawTargetCairo::Snapshot ]
status-firefox54:
--- → wontfix
status-firefox55:
--- → wontfix
status-firefox-esr52:
--- → wontfix
You need to log in
before you can comment on or make changes to this bug.
Description
•