Closed
Bug 1380454
Opened 7 years ago
Closed 7 years ago
port retrigger to action.json
Categories
(Taskcluster :: Services, defect)
Taskcluster
Services
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla56
People
(Reporter: bstack, Assigned: bstack)
References
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ee23e37810b3
Assignee | ||
Comment 2•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6fdca82b530b
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8887979 [details] Bug 1380454 - Port retrigger to actions.json https://reviewboard.mozilla.org/r/158848/#review164340 ::: taskcluster/actions/registry.py:30 (Diff revision 1) > except ValueError: > return False > return True > > > -def register_task_action(name, title, description, order, context, schema): > +def register_task_action(name, title, description, order, context, schema={}): It says below and in the docs that schema can be omitted. It doesn't look like the Python quite implements that, but that should probably be fixed (just default to None, and when rendering to JSON, conditionally omit schema) ::: taskcluster/actions/retrigger.py:9 (Diff revision 1) > + title='Retrigger', > + description="Create a clone of the task", > + order=1, > + context=[{}], > +) > +def retrigger_task_builder(parameters): This is so cool :)
Attachment #8887979 -
Flags: review?(dustin) → review+
Assignee | ||
Comment 5•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7fa1374d58ad
Comment hidden (mozreview-request) |
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8887979 [details] Bug 1380454 - Port retrigger to actions.json https://reviewboard.mozilla.org/r/158848/#review164898
Pushed by dmitchell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ec7291c0411c Port retrigger to actions.json r=dustin
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ec7291c0411c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Updated•5 years ago
|
Component: Integration → Services
You need to log in
before you can comment on or make changes to this bug.
Description
•