Closed Bug 1380521 Opened 4 years ago Closed 4 years ago

initial reflow of select with 0-height options produces wrong size for select

Categories

(Core :: Layout: Form Controls, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: dbaron, Assigned: dbaron)

References

Details

Attachments

(3 files)

The initial reflow of a select with 0-height options produces the wrong size for that select.

This causes a failure in layout/reftests/bugs/467084-1.html , with the patches in bug 1308876, on Android only (or on all platforms if I add 'html { overflow: hidden }').
Blocks: 1308876
It's just asserting the same as the test that contains it.

MozReview-Commit-ID: KS58GuvVZDA
Attachment #8885973 - Flags: review?(dholbert)
MozReview-Commit-ID: 6i2cz2Flwtb
Attachment #8885974 - Flags: review?(dholbert)
This fixes a failure in layout/reftests/bugs/467084-1.html, triggered by
the primary patch in bug 1308876, on Android only (or on all platforms
if I add 'html { overflow: hidden }').

I confirmed locally (on Linux) that, without this patch, both
layout/reftests/bugs/467084-1.html with 'html { overflow: hidden }', and
the reftest added here, fail, but that with the patch they both pass.

MozReview-Commit-ID: 3SjTlnBngBV
Attachment #8885975 - Flags: review?(dholbert)
Attachment #8885973 - Flags: review?(dholbert) → review+
Attachment #8885974 - Flags: review?(dholbert) → review+
Comment on attachment 8885975 [details] [diff] [review]
Use a more reliably invalid initial mBSizeOfARow so that we reflow properly if it changes to zero

Review of attachment 8885975 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, one optional suggestion:

::: layout/reftests/forms/select/listbox-zero-row-initial-ref.html
@@ +1,2 @@
> +<!DOCTYPE HTML>
> +<title>Testcase for initial reflow of zero height options</title>

Maybe s/Testcase/Reference case/ so you can tell the two files apart easier when comparing them in adjacent tabs?
Attachment #8885975 - Flags: review?(dholbert) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/5631a4402393f2b4f16b4f959436eea1e717fe43
Bug 1380521 - Remove pointless assertion.  r=dholbert

https://hg.mozilla.org/integration/mozilla-inbound/rev/4bf16638687ffa908a78d7ab2d04320c36afcaba
Bug 1380521 - Fix spelling of mSuppressScrollbarUpdate member variable.  r=dholbert

https://hg.mozilla.org/integration/mozilla-inbound/rev/f8c5d7e8c28ad64e495e0534d40975d8ab736772
Bug 1380521 - Use a more reliably invalid initial mBSizeOfARow so that we reflow properly if it changes to zero.  r=dholbert
https://hg.mozilla.org/mozilla-central/rev/5631a4402393
https://hg.mozilla.org/mozilla-central/rev/4bf16638687f
https://hg.mozilla.org/mozilla-central/rev/f8c5d7e8c28a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Type: enhancement → defect
You need to log in before you can comment on or make changes to this bug.