Closed Bug 1380560 Opened 4 years ago Closed 4 years ago

[Mac] Issue strong warning or exit browser on local builds if MOZ_DEVELOPER_REPO_DIR not set

Categories

(Core :: Security: Process Sandboxing, enhancement)

56 Branch
enhancement
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1380690

People

(Reporter: haik, Unassigned)

References

Details

(Whiteboard: sbmc2)

On the Mac, for unpackaged builds, we depend on the MOZ_DEVELOPER_REPO_DIR being set with the path to the source repo. We do this because an unpackaged build .app/ dir contains symlinks back to the source tree and in order for these symlinks to be resolvable, the content sandbox must know the path to the repo so that it can permit read access to those files.

mach has been updated to set MOZ_DEVELOPER_REPO_DIR when launching the browser or running tests, but executing Firefox directly as in

  $ ./obj/dist/Nightly.app/Contents/MacOS/firefox

requires MOZ_DEVELOPER_REPO_DIR to be manually set in the environment. Given that there are scenarios where the browser will crash without this environment variable set, we should issue a strong warning or exit the browser if the variable is not set.
See Also: → 1380416, 1380141
Whiteboard: sbmc2
See Also: → 1380132
With the fix for 1380690, Mac builds are no longer dependent on the MOZ_DEVELOPER_REPO_DIR environment variable. The repo path and object dir path are obtained from a plist file in the Mac application bundle and the the browser crashes on startup when the build is unbundled and we fail to read the paths.
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1380690
You need to log in before you can comment on or make changes to this bug.