1380583 - Newtab thumbnails got from 4x2 to 4x3

Status: RESOLVED INVALID

(Firefox :: New Tab Page, defect)

Description

[Marco Castelluccio [:marco]]

I've never changed the default preferences "browser.newtabpage.rows" and "browser.newtabpage.columns".

Before 1369287, I had 4x2 thumbnails in my about:newtab page.
After 1369287's backout, I have 4x3 thumbnails in my about:newtab page.

I can't reproduce in a clean profile, so there must be something wrong with mine.

Comment 1

[:Gijs (he/him)]

Are any of the browser.newtab prefs in your profile non-default, when checking in about:config ? Pinned sites, for instance? Do you see the same thing with the profile that has this issue in safe mode (ie without add-ons) ?

Comment 2

[Marco Castelluccio [:marco]]

(In reply to :Gijs (no reviews, mostly out until Jul 17) from comment #1)
> Are any of the browser.newtab prefs in your profile non-default, when
> checking in about:config ? Pinned sites, for instance?

All the preferences whose name contains "newtab" are the same between the clean and the dirty profiles.

> Do you see the same
> thing with the profile that has this issue in safe mode (ie without add-ons)
> ?

Yes.

Comment 3

[:Gijs (he/him)]

(In reply to Marco Castelluccio [:marco] from comment #2)
> (In reply to :Gijs (no reviews, mostly out until Jul 17) from comment #1)
> > Are any of the browser.newtab prefs in your profile non-default, when
> > checking in about:config ? Pinned sites, for instance?
> 
> All the preferences whose name contains "newtab" are the same between the
> clean and the dirty profiles.
> 
> > Do you see the same
> > thing with the profile that has this issue in safe mode (ie without add-ons)
> > ?
> 
> Yes.

If you visit 10 different domains in a new profile, do you end up with 4x3 tiles?

On beta, I get 4x3 tiles, so I expect this is simply normal, and the only reason you see 4x2 on a clean profile is that there is no history, so there simply aren't any more tiles to be displayed.

Comment 4

[Marco Castelluccio [:marco]]

(In reply to :Gijs from comment #3)
> (In reply to Marco Castelluccio [:marco] from comment #2)
> > (In reply to :Gijs (no reviews, mostly out until Jul 17) from comment #1)
> > > Are any of the browser.newtab prefs in your profile non-default, when
> > > checking in about:config ? Pinned sites, for instance?
> > 
> > All the preferences whose name contains "newtab" are the same between the
> > clean and the dirty profiles.
> > 
> > > Do you see the same
> > > thing with the profile that has this issue in safe mode (ie without add-ons)
> > > ?
> > 
> > Yes.
> 
> If you visit 10 different domains in a new profile, do you end up with 4x3
> tiles?
> 
> On beta, I get 4x3 tiles, so I expect this is simply normal, and the only
> reason you see 4x2 on a clean profile is that there is no history, so there
> simply aren't any more tiles to be displayed.

You're right, I guess my memory doesn't serve me well.