Closed
Bug 1380718
Opened 7 years ago
Closed 7 years ago
Include the operation name in bookmark validation errors
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: lina, Assigned: lina)
References
Details
Attachments
(1 file)
Mark noticed an uptick in `Error: Invalid value for property 'guid': null` errors causing bookmark syncs to fail in 54. The Sync telemetry ping includes the error message, but not the stack (to avoid noise?). I think annotating the callers of `validateItemProperties` with the operation name would help us track this down.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8886249 [details] Bug 1380718 - Include the operation name in bookmark validation errors. https://reviewboard.mozilla.org/r/157024/#review162506 SGTM!
Attachment #8886249 -
Flags: review?(mak77) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f2d6f49d02c273ed53e053724c6f45ba0891fae
Pushed by kcambridge@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b8f66d5a9748 Include the operation name in bookmark validation errors. r=mak
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/b8f66d5a9748
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•