1380743 - Remove gcc/ entries from grcov's output

Status: RESOLVED FIXED

(Testing :: Code Coverage, enhancement)

Description

[Marco Castelluccio [:marco]]

We have SF entries in the grcov output like:
SF:gcc/include/c++/4.9.4/tr1/hashtable_policy.h
SF:gcc/include/c++/4.9.4/initializer_list
SF:gcc/include/c++/4.9.4/bits/basic_string.h
SF:gcc/include/c++/4.9.4/bits/stl_algo.h
SF:gcc/include/c++/4.9.4/cmath
SF:gcc/include/c++/4.9.4/iostream
SF:gcc/include/c++/4.9.4/bits/allocator.h
SF:gcc/include/c++/4.9.4/bits/basic_string.tcc
SF:gcc/include/c++/4.9.4/x86_64-unknown-linux-gnu/bits/gthr-default.h
SF:gcc/include/c++/4.9.4/sstream
SF:gcc/include/c++/4.9.4/bits/atomic_base.h
SF:gcc/include/c++/4.9.4/bits/ios_base.h
SF:gcc/include/c++/4.9.4/bits/predefined_ops.h
SF:gcc/include/c++/4.9.4/bits/stl_algobase.h
SF:gcc/include/c++/4.9.4/bits/char_traits.h
SF:gcc/include/c++/4.9.4/iomanip
SF:gcc/include/c++/4.9.4/atomic
SF:gcc/include/c++/4.9.4/bits/locale_facets.h
SF:gcc/include/c++/4.9.4/ext/new_allocator.h
SF:gcc/include/c++/4.9.4/ext/atomicity.h
SF:gcc/include/c++/4.9.4/bits/stl_pair.h
SF:gcc/include/c++/4.9.4/bits/stl_heap.h
SF:gcc/include/c++/4.9.4/thread
SF:gcc/include/c++/4.9.4/ostream
SF:gcc/include/c++/4.9.4/bits/move.h
SF:gcc/include/c++/4.9.4/typeinfo

We don't really need them, as they are not part of the Firefox source code.

Comment 1

[Marco Castelluccio [:marco]]

Attachment: Patch

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8886280 [details] [diff] [review]
Patch

Review of attachment 8886280 [details] [diff] [review]:
-----------------------------------------------------------------

I am fine adjusting this patch or doing a follow up if we decide to do more 3rd party libraries.

::: testing/mozharness/mozharness/mozilla/testing/codecoverage.py
@@ +133,5 @@
> +            grcov_command = [
> +                os.path.join(self.grcov_dir, 'grcov'),
> +                '-t', 'lcov',
> +                '-p', '/home/worker/workspace/build/src/',
> +                '--ignore-dir', 'gcc',

should we ignore other third_party files as well?  I know this isn't third party in the sense that we need it to make firefox work this is just the compiler.  Here is a mostly comprehensive list:
https://dxr.mozilla.org/mozilla-central/source/tools/rewriting/ThirdPartyPaths.txt

Comment 3

[Marco Castelluccio [:marco]]

(In reply to Joel Maher ( :jmaher) (UTC-8) from comment #2)
> Comment on attachment 8886280 [details] [diff] [review]
> Patch
> 
> Review of attachment 8886280 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I am fine adjusting this patch or doing a follow up if we decide to do more
> 3rd party libraries.
> 
> ::: testing/mozharness/mozharness/mozilla/testing/codecoverage.py
> @@ +133,5 @@
> > +            grcov_command = [
> > +                os.path.join(self.grcov_dir, 'grcov'),
> > +                '-t', 'lcov',
> > +                '-p', '/home/worker/workspace/build/src/',
> > +                '--ignore-dir', 'gcc',
> 
> should we ignore other third_party files as well?  I know this isn't third
> party in the sense that we need it to make firefox work this is just the
> compiler.  Here is a mostly comprehensive list:
> https://dxr.mozilla.org/mozilla-central/source/tools/rewriting/
> ThirdPartyPaths.txt

It makes sense, I will file a follow-up to investigate it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/17dd6a9a4b5b
Ignore gcc/** files when generating info file via grcov. r=jmaher

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/17dd6a9a4b5b