1380777 - Windows and mac release promotion l10n repacks fail to download en-US

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, enhancement, P1)

Description

[Rail Aliiev [:rail]]

Running repacks with '--platform-config single_locale/win64.py' breaks the builds because we use target

12:06:53     INFO -  (cd c:/builds/moz2_slave/rel-jamun_fx_w64_l10n_rpk-0000/build/jamun/obj-l10n/dist/ && \
12:06:53     INFO -          wget --no-cache -nv --no-iri -N -O firefox-56.0.en-US.win64.zip 'https://queue.taskcluster.net/v1/task/NQ1jSP-7Rnyhw2dBjbadrA/artifacts/public/build/firefox-56.0.en-US.win64.zip')
12:06:53     INFO -  WARNING: timestamping does nothing in combination with -O. See the manual
12:06:53     INFO -  for details.
12:06:54     INFO -  https://queue.taskcluster.net/v1/task/NQ1jSP-7Rnyhw2dBjbadrA/artifacts/public/build/firefox-56.0.en-US.win64.zip:
12:06:54     INFO -  2017-07-13 12:06:54 ERROR 404: Not Found.
12:06:54     INFO -  c:/builds/moz2_slave/rel-jamun_fx_w64_l10n_rpk-0000/build/jamun/toolkit/locales/l10n.mk:201: recipe for target 'wget-en-US' failed

Comment 1

[Rail Aliiev [:rail]]

Hopefully this helps: https://hg.mozilla.org/projects/jamun/rev/3e85811d54c7fef23fe39ce1665b02c08206c176

Comment 2

[Rail Aliiev [:rail]]

Something tells me that we don't even use the zip: https://hg.mozilla.org/projects/jamun/rev/93acee63e5b91ab73adec1b4f8a3c71147b065e0

Comment 3

[Rail Aliiev [:rail]]

testing https://hg.mozilla.org/projects/jamun/rev/a481f13bbf0a

Comment 4

[Rail Aliiev [:rail]]

Attachment: Bug 1380777 - Override EN_US_INSTALLER_BINARY_URL via buldbot properties DONTBUILD

Review commit: https://reviewboard.mozilla.org/r/158292/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158292/

Comment 5

[Rail Aliiev [:rail]]

Attachment: EN_US_PACKAGE_NAME and EN_US_PKG_INST_BASENAME mozharness configs

This patch is ready to be landed when we decide to switch to TC.

Comment 6

[Justin Wood (:Callek)]

Comment on attachment 8887453 [details]
Bug 1380777 - Override EN_US_INSTALLER_BINARY_URL via buldbot properties  DONTBUILD

https://reviewboard.mozilla.org/r/158292/#review163494

::: testing/mozharness/scripts/desktop_l10n.py:376
(Diff revision 1)
>          bootstrap_env = self.query_env(partial_env=config.get("bootstrap_env"),
>                                         replace_dict=replace_dict)
> +        # Override en_us_installer_binary_url if passed as a buildbot property
> +        if self.buildbot_config["properties"].get("en_us_installer_binary_url"):
> +            bootstrap_env['EN_US_INSTALLER_BINARY_URL'] = str(
> +                    self.buildbot_config["properties"]["en_us_installer_binary_url"])

please do `self.info("Overriding..."` like above.

Comment 7

[Rail Aliiev [:rail]]

Comment on attachment 8887453 [details]
Bug 1380777 - Override EN_US_INSTALLER_BINARY_URL via buldbot properties  DONTBUILD

https://reviewboard.mozilla.org/r/158292/#review163528

::: testing/mozharness/scripts/desktop_l10n.py:376
(Diff revision 1)
>          bootstrap_env = self.query_env(partial_env=config.get("bootstrap_env"),
>                                         replace_dict=replace_dict)
> +        # Override en_us_installer_binary_url if passed as a buildbot property
> +        if self.buildbot_config["properties"].get("en_us_installer_binary_url"):
> +            bootstrap_env['EN_US_INSTALLER_BINARY_URL'] = str(
> +                    self.buildbot_config["properties"]["en_us_installer_binary_url"])

Good catch!

Comment 8

[Rail Aliiev [:rail]]

Comment on attachment 8887453 [details]
Bug 1380777 - Override EN_US_INSTALLER_BINARY_URL via buldbot properties  DONTBUILD

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158292/diff/1-2/

Comment 9

[Rail Aliiev [:rail]]

Comment on attachment 8887453 [details]
Bug 1380777 - Override EN_US_INSTALLER_BINARY_URL via buldbot properties  DONTBUILD

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158292/diff/2-3/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e38374a75acd
Override EN_US_INSTALLER_BINARY_URL via buldbot properties r=Callek DONTBUILD

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e38374a75acd

Comment 12

[Rail Aliiev [:rail]]

Comment on attachment 8887455 [details] [diff] [review]
EN_US_PACKAGE_NAME and EN_US_PKG_INST_BASENAME mozharness configs

to be landed when we decide to switch

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dc9de4bcb156
Windows and mac release promotion l10n repacks fail to download en-US r=Callek

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dc9de4bcb156