1380792 - Login item edit mode UI bug: incorrect indent of username and password

Status: RESOLVED WONTFIX

(Firefox for iOS :: Login Management, defect)

Description

[:garvan]

Attachment: Screen Shot 2017-07-13 at 3.59.47 PM.png

STR: Tap on a login row in the login list to get to the login detail screen, then tap Edit on upper-right.
The username and password indents significantly (which it shouldn't) as per screenshot.

Comment 1

[:garvan]

I wonder was there some specific intent here and perhaps over time (newer iOS) it got into an odd-looking state?
Robin, pinging you to see if you recall anything about the UX intention for this screen

Comment 2

[Robin Andersen [:tecgirl]]

Attachment: Fx-iOS-Login-Management.png

The intent of the indent is to visually denote "edit mode".

Comment 3

[:garvan]

Disagree with the WONTFIX, looks like there is a mismatch between the UI spec and how this was interpreted. 
The UI spec shows the sitename indented with an icon to the left. In that case, the indent makes sense as all the items would be aligned.

Comment 4

[:garvan]

Can we left-align all the fields? 

I think the disconnect from design-to-implementation is that the design has fields for both name (a.k.a title) and website, which I don't see implemented in the code, there is only the website.
The edit indent in the design aligns with the site icon in the name/title field. 
Because that wasn't implemented, the indent doesn't align with anything ATM.

Comment 5

[Robin Andersen [:tecgirl]]

while it's true we never added the favicon, I still feel the indent helps the user identify what's editable. the address field is not, and our color blind users might not notice the color change in the username/password headers.

Comment 6

[:garvan]

Ok, wontfix until all the fields become editable (no idea why website is not).