138081 - nsDataChannel::ParseData leaks on various failures

Status: VERIFIED FIXED

(Core :: Networking, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

dataToWrite is leaked on all those wonderful |if (NS_FAILED(rv)) return rv;|
blocks that come after it has been allocated.  If we're dealing with non-text
data, dataBuffer is leaked as well.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Patch v1.0

Comment 2

[Boris Zbarsky [:bzbarsky]]

to me

Comment 3

[Darin Fisher]

Comment on attachment 79735 [details] [diff] [review]
Patch v1.0

Index: protocol/data/src/nsDataChannel.cpp

>@@ -204,12 +211,18 @@

>+        // XXX PL_Base64Decode will return a null pointer for decoding
>+        // errors.  Since those are more likely than out-of-memory,
>+        // should we return NS_ERROR_MALFORMED_URI instead?

how about NS_ERROR_UNEXPECTED?

nice work! sr=darin

Comment 4

[Boris Zbarsky [:bzbarsky]]

Checked in on trunk, with NS_ERROR_UNEXPECTED as the error.

Comment 5

[Boris Zbarsky [:bzbarsky]]

This does not build on Windows, apparently.  I backed it out and will work on a
different fix.

Comment 6

[Boris Zbarsky [:bzbarsky]]

OK, this builds on windows if I move the      

PRUint32 dataLen = PL_strlen(dataBuffer);

line to before the goto that's above it.  So I'll be relanding this with that
change...

Comment 7

[Boris Zbarsky [:bzbarsky]]

relanded

Comment 8

[John Unruh]

Verified per bzbarsky's comments.