Closed Bug 1380811 Opened 7 years ago Closed 7 years ago

Add telemetry to track trending stories success

Categories

(Firefox for Android Graveyard :: General, enhancement, P1)

All
Android
enhancement

Tracking

(firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: liuche, Assigned: liuche)

References

Details

(Whiteboard: [MobileAS])

Attachments

(1 file)

There is existing telemetry for the Highlights and Topsites section. Make sure this telemetry also reports Pocket stories correctly. 

We should be able to track the engagement of trending stories and maybe in the future compare pocket stories to highlights.
Whiteboard: MobileAS → [MobileAS]
Rank: 1
Picking this up bc all other bugs in the sprint are assigned/blocked.
Assignee: nobody → liuche
Iteration: --- → 1.29
Priority: P2 → P1
Actually this should wait until context menus have been finished in bug 1394459.
Iteration: 1.29 → ---
Depends on: 1394459
Priority: P1 → P2
Rank: 1
Priority: P2 → P1
Iteration: --- → 1.30
Verified additional telemetry that we already get from Highlights:
* Item click
* Context menu
Comment on attachment 8906873 [details]
Bug 1380811 - Add telemetry to collect boolean state for toggle preference.

https://reviewboard.mozilla.org/r/178606/#review184042

::: mobile/android/base/java/org/mozilla/gecko/widget/SwitchPreferenceView.java:64
(Diff revision 1)
>          setOnCheckedChangeListener(new CompoundButton.OnCheckedChangeListener() {
>              @Override
>              public void onCheckedChanged(CompoundButton compoundButton, boolean b) {
>                  sharedPreferences.edit().putBoolean(preferenceKey, b).apply();
> +
> +                final JSONArray extras = new JSONArray();

nit: do we want this to be a JSONObject? So that it's preferenceKey -> b? (the key -> value)
Attachment #8906873 - Flags: review?(michael.l.comella) → review+
Comment on attachment 8906873 [details]
Bug 1380811 - Add telemetry to collect boolean state for toggle preference.

https://reviewboard.mozilla.org/r/178606/#review184042

> nit: do we want this to be a JSONObject? So that it's preferenceKey -> b? (the key -> value)

I expect how the extras are laid out will depend on how the analysis tools are structured so that we can query those values (I assume we can easily query JSON extras?).
Comment on attachment 8906873 [details]
Bug 1380811 - Add telemetry to collect boolean state for toggle preference.

https://reviewboard.mozilla.org/r/178606/#review184046

This is category 2 data, datareview+
Attachment #8906873 - Flags: review?(francois) → review+
Comment on attachment 8906873 [details]
Bug 1380811 - Add telemetry to collect boolean state for toggle preference.

https://reviewboard.mozilla.org/r/178606/#review184042

> I expect how the extras are laid out will depend on how the analysis tools are structured so that we can query those values (I assume we can easily query JSON extras?).

Yep! Good call though, I matched this to how we're doing it in GeckoPreferences:
http://searchfox.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferences.java#1095
Pushed by cliu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9fbfe01ae6f1
Add telemetry to collect boolean state for toggle preference. r=francois,mcomella
https://hg.mozilla.org/mozilla-central/rev/9fbfe01ae6f1
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.