1380815 - Fade overflow menu icon to grey after item is pinned

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[Eric Pang [:epang] UX]

After an item is pinned the over flow menu the icon should fade from blue to grey.

After the icon motion the icon should stay blue (#0a84ff) for 520ms.

Then fade to grey (#0c0c0c) in 210ms.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1380815 - Fade overflow menu icon to grey after item is pinned.

Review commit: https://reviewboard.mozilla.org/r/159272/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159272/

Comment 2

[Sam Foster [:sfoster] (he/him)]

jared, I'm not sure what to do to see this animation. I guessed I would be dropping icons into the overflow panel in the customize screen, but I see no animations or color changes when I do that? (I did check I have animations enabled.) Is there a mockup or spec for this other than Eric's description?

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

This animation is only run when the user right-clicks on an item in the toolbar outside of customization mode and chooses "Pin to Overflow Menu"

Comment 4

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8888326 [details]
Bug 1380815 - Fade overflow menu icon to grey after item is pinned.

https://reviewboard.mozilla.org/r/159272/#review164950

Looks good. Was going to add a nit to comment on why you've got a 730ms animation when Eric calls for 510ms (71% of 730ms is 510ms, so the animations run concurrently but the fade starts at the right time). But I figured it out quickly enough so maybe just a note in the bug is enough? 

We should get some specs on this bug, or link it to one with specs as right now its blocking nothing and has no reference material attached to it.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Sam Foster [:sfoster] from comment #4)
> Comment on attachment 8888326 [details]
> Bug 1380815 - Fade overflow menu icon to grey after item is pinned.
> 
> https://reviewboard.mozilla.org/r/159272/#review164950
> 
> Looks good. Was going to add a nit to comment on why you've got a 730ms
> animation when Eric calls for 510ms (71% of 730ms is 510ms, so the
> animations run concurrently but the fade starts at the right time). But I
> figured it out quickly enough so maybe just a note in the bug is enough? 

Okay, I can add a comment in the CSS.
 
> We should get some specs on this bug, or link it to one with specs as right
> now its blocking nothing and has no reference material attached to it.

The specs are in comment 0.

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8888326 [details]
Bug 1380815 - Fade overflow menu icon to grey after item is pinned.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159272/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/571f64d55017
Fade overflow menu icon to grey after item is pinned. r=sfoster

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/571f64d55017

Comment 9

[Azmina]

I have reproduced this bug with Nightly 56.0a1 (2017-07-13) on Windows 8.1 (64 Bit)

This bug's fix is verified on Latest Nightly 56.0a1.

Build ID : 20170801100311
User Agent : Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0

Comment 10

[Justin [:JW_SoftvisionQA]]

I have verified this fix on today's nightly.