Closed Bug 1380815 Opened 3 years ago Closed 3 years ago

Fade overflow menu icon to grey after item is pinned

Categories

(Firefox :: Theme, defect, P1)

56 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 56
Iteration:
56.3 - Jul 24
Tracking Status
firefox56 --- fixed

People

(Reporter: epang, Assigned: jaws)

References

(Blocks 1 open bug)

Details

(Whiteboard: [photon-animation])

Attachments

(1 file)

After an item is pinned the over flow menu the icon should fade from blue to grey.

After the icon motion the icon should stay blue (#0a84ff) for 520ms.

Then fade to grey (#0c0c0c) in 210ms.
Whiteboard: [photon-animation] → [photon-animation][triage]
Assignee: jaws → nobody
Flags: qe-verify+
QA Contact: jwilliams
Whiteboard: [photon-animation][triage] → [photon-animation]
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Iteration: --- → 56.3 - Jul 24
Priority: P2 → P1
jared, I'm not sure what to do to see this animation. I guessed I would be dropping icons into the overflow panel in the customize screen, but I see no animations or color changes when I do that? (I did check I have animations enabled.) Is there a mockup or spec for this other than Eric's description?
Flags: needinfo?(jaws)
This animation is only run when the user right-clicks on an item in the toolbar outside of customization mode and chooses "Pin to Overflow Menu"
Flags: needinfo?(jaws)
Comment on attachment 8888326 [details]
Bug 1380815 - Fade overflow menu icon to grey after item is pinned.

https://reviewboard.mozilla.org/r/159272/#review164950

Looks good. Was going to add a nit to comment on why you've got a 730ms animation when Eric calls for 510ms (71% of 730ms is 510ms, so the animations run concurrently but the fade starts at the right time). But I figured it out quickly enough so maybe just a note in the bug is enough? 

We should get some specs on this bug, or link it to one with specs as right now its blocking nothing and has no reference material attached to it.
Attachment #8888326 - Flags: review?(sfoster) → review+
(In reply to Sam Foster [:sfoster] from comment #4)
> Comment on attachment 8888326 [details]
> Bug 1380815 - Fade overflow menu icon to grey after item is pinned.
> 
> https://reviewboard.mozilla.org/r/159272/#review164950
> 
> Looks good. Was going to add a nit to comment on why you've got a 730ms
> animation when Eric calls for 510ms (71% of 730ms is 510ms, so the
> animations run concurrently but the fade starts at the right time). But I
> figured it out quickly enough so maybe just a note in the bug is enough? 

Okay, I can add a comment in the CSS.
 
> We should get some specs on this bug, or link it to one with specs as right
> now its blocking nothing and has no reference material attached to it.

The specs are in comment 0.
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/571f64d55017
Fade overflow menu icon to grey after item is pinned. r=sfoster
https://hg.mozilla.org/mozilla-central/rev/571f64d55017
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
I have reproduced this bug with Nightly 56.0a1 (2017-07-13) on Windows 8.1 (64 Bit)

This bug's fix is verified on Latest Nightly 56.0a1.

Build ID : 20170801100311
User Agent : Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
QA Whiteboard: [bugday-20170802]
QA Contact: jwilliams → stefan.georgiev
I have verified this fix on today's nightly.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.