1380817 - Update Screenshots to version 10.5.0

Status: VERIFIED FIXED

(Firefox :: Screenshots, defect)

Description

[Ian Bicking (:ianbicking)]

Changelog for 10.5.0: https://github.com/mozilla-services/screenshots/blob/efb41d02786e77153e4a99d3d7fe328653077071/CHANGELOG.md#version-1050

- Disable Screenshots in private windows. Fixes #3120 https://github.com/mozilla-services/screenshots/issues/3120 https://github.com/mozilla-services/screenshots/commit/450dad1
- Do not regress the already-landed fix to Bug 1373614 (stop the embedded WebExtension unconditionally) https://github.com/mozilla-services/screenshots/commit/cf3788d

Note that 10.4.0 landed in Bug 1380119 but was backed out. So this includes all the changes from 10.4.0 as well:

Changelog: https://github.com/mozilla-services/screenshots/blob/1bcbddaa4f805ce7237606d0628dbc2e87cae7f4/CHANGELOG.md#version-1040

- Add context fill icons https://github.com/mozilla-services/screenshots/commit/7cb237f

- Sanitize download filename more fully. This adds : (important on Windows), \, <, and > to the blacklist. Followup in https://github.com/mozilla-services/screenshots/issues/3083 Fixes https://github.com/mozilla-services/screenshots/issues/2981 https://github.com/mozilla-services/screenshots/commit/af32978

- Add cloud icon to Save https://github.com/mozilla-services/screenshots/commit/4ae42cc

Comment 1

[Ian Bicking (:ianbicking)]

Attachment: Bug 1380817 - Export Screenshots 10.5.0 to Firefox;

Review commit: https://reviewboard.mozilla.org/r/157112/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157112/

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 8886367 [details]
Bug 1380817 - Export Screenshots 10.5.0 to Firefox;

https://reviewboard.mozilla.org/r/157112/#review162286

This seems to be missing the newly added strings from the private browsing change.

Comment 3

[Ian Bicking (:ianbicking)]

Comment on attachment 8886367 [details]
Bug 1380817 - Export Screenshots 10.5.0 to Firefox;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157112/diff/1-2/

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 8886367 [details]
Bug 1380817 - Export Screenshots 10.5.0 to Firefox;

https://reviewboard.mozilla.org/r/157112/#review162580

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40bef89faa11
Export Screenshots 10.5.0 to Firefox; r=mossop

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/40bef89faa11

Comment 7

[Ian Bicking (:ianbicking)]

Comment on attachment 8886367 [details]
Bug 1380817 - Export Screenshots 10.5.0 to Firefox;

Approval Request Comment
[Feature/Bug causing the regression]:
Screenshots

[User impact if declined]:
- People using Screenshots in a Private Browsing window will have their downloads listed in the main download manager
- Users with dark themes cannot see the icon
- Windows users encounter download issues with many sites
- That "Save" leads to an upload may confuse some users

[Is this code covered by automated tests?]:
No

[Has the fix been verified in Nightly?]:
Yes

[Needs manual test from QE? If yes, steps to reproduce]: 
SoftVision has QA'd this

[List of other uplifts needed for the feature/fix]:
Bug 1377302 and Bug 1379464 (for dark theme support)

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
Changes are to the WebExtension portion of Screenshots

[String changes made/needed]:
No (it does include a string addition, but we're localizing outside of the Firefox process, a future update will include translations for the new string)

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 8886367 [details]
Bug 1380817 - Export Screenshots 10.5.0 to Firefox;

screenshots update for fx55, should be in 55.0b10

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e26b1f5d635e

Comment 10

[Iulia Cristescu, QA [:JuliaC] (away, please needinfo? [e-mail])]

The fixes stated in comment 0 reached Firefox Nightly 56.0a1 (2017-07-15) and Firefox 55.0b10 build1 (20170717063821). Marking this issue as verified.