Update Screenshots to version 10.5.0

VERIFIED FIXED in Firefox 55

Status

()

defect
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: ianbicking, Assigned: ianbicking)

Tracking

unspecified
Firefox 56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 verified, firefox56 verified)

Details

Attachments

(1 attachment)

Assignee

Updated

2 years ago
Assignee: nobody → ianb
Comment hidden (mozreview-request)

Comment 2

2 years ago
mozreview-review
Comment on attachment 8886367 [details]
Bug 1380817 - Export Screenshots 10.5.0 to Firefox;

https://reviewboard.mozilla.org/r/157112/#review162286

This seems to be missing the newly added strings from the private browsing change.
Attachment #8886367 - Flags: review?(dtownsend) → review-
Comment hidden (mozreview-request)

Comment 4

2 years ago
mozreview-review
Comment on attachment 8886367 [details]
Bug 1380817 - Export Screenshots 10.5.0 to Firefox;

https://reviewboard.mozilla.org/r/157112/#review162580
Attachment #8886367 - Flags: review?(dtownsend) → review+
Assignee

Updated

2 years ago
Keywords: checkin-needed
Assignee

Updated

2 years ago
Blocks: 1381132

Comment 5

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/40bef89faa11
Export Screenshots 10.5.0 to Firefox; r=mossop
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/40bef89faa11
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Assignee

Comment 7

2 years ago
Comment on attachment 8886367 [details]
Bug 1380817 - Export Screenshots 10.5.0 to Firefox;

Approval Request Comment
[Feature/Bug causing the regression]:
Screenshots

[User impact if declined]:
- People using Screenshots in a Private Browsing window will have their downloads listed in the main download manager
- Users with dark themes cannot see the icon
- Windows users encounter download issues with many sites
- That "Save" leads to an upload may confuse some users

[Is this code covered by automated tests?]:
No

[Has the fix been verified in Nightly?]:
Yes

[Needs manual test from QE? If yes, steps to reproduce]: 
SoftVision has QA'd this

[List of other uplifts needed for the feature/fix]:
Bug 1377302 and Bug 1379464 (for dark theme support)

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
Changes are to the WebExtension portion of Screenshots

[String changes made/needed]:
No (it does include a string addition, but we're localizing outside of the Firefox process, a future update will include translations for the new string)
Attachment #8886367 - Flags: approval-mozilla-beta?
Comment on attachment 8886367 [details]
Bug 1380817 - Export Screenshots 10.5.0 to Firefox;

screenshots update for fx55, should be in 55.0b10
Attachment #8886367 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
The fixes stated in comment 0 reached Firefox Nightly 56.0a1 (2017-07-15) and Firefox 55.0b10 build1 (20170717063821). Marking this issue as verified.
Status: RESOLVED → VERIFIED
Target Milestone: --- → mozilla56
Target Milestone: mozilla56 → Firefox 56

Updated

2 years ago
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.