Closed Bug 1380846 Opened 7 years ago Closed 7 years ago

Add search engine to vietnamese build for coccoc.com

Categories

(Firefox :: Search, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 56
Tracking Status
firefox55 - fixed
firefox56 --- fixed

People

(Reporter: mkaply, Assigned: mkaply)

Details

Attachments

(1 file, 1 obsolete file)

Attached file XML file for initial review (obsolete) —
We're adding a new search engine for Vietnamese.

XML file attached. Full patch coming.
Attachment #8886396 - Flags: review?(francesco.lodolo)
I should be able to do a proper review early next week.

They seem to support https, is there a request on their side to use http?

I've just seen a bug for mobile (bug 1380866), is this request desktop only or should we try to catch Fennec too?
I wasn't aware of the work in bug 1380866. I'll check with Christopher Arnold on this. I know we've been chatting with coccoc.
> They seem to support https, is there a request on their side to use http?

And they do have https. I'll update the patch.
Attachment #8886396 - Attachment is obsolete: true
Attachment #8886396 - Flags: review?(francesco.lodolo)
Comment on attachment 8886649 [details]
Bug 1380846 - Add coccoc to Vietnamese desktop build.

https://reviewboard.mozilla.org/r/157442/#review162770

Tested, search plugin installs correctly and works as expected. I wonder if we should wait for the outcome of bug 1380866 before pushing? I guess that's carnold's call
Attachment #8886649 - Flags: review?(francesco.lodolo) → review+
> I wonder if we should wait for the outcome of bug 1380866 before pushing? I guess that's carnold's call

I think desktop is more important here, so I'd like to go ahead and put this one in. We can have the mobile discussion separately.
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/6d6a00964ace
Add coccoc to Vietnamese desktop build. r=flod
https://hg.mozilla.org/mozilla-central/rev/6d6a00964ace
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
I have reproduced this Bug on Nightly 56.0a1 (2017-07-13) vietnamese build on Windows 10, 64 bit!

The bug's fix is now verified on latest  Nightly 56.0a1 (Vietnamese build)

Build ID    :	20170720030203
User Agent  : 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
QA Whiteboard: [bugday-20170719]
Thank you team!  I would like to request uplift on this patch for 56.  The introduction of this popular search provider is low risk for us and we plan some social mentions and PR around the incorporation that we hope will benefit our end user engagement.  This is unique to the Vietnamese build.
Comment on attachment 8886649 [details]
Bug 1380846 - Add coccoc to Vietnamese desktop build.

Approval Request Comment
[Feature/Bug causing the regression]: New search engine for Vietnamese
[User impact if declined]: No search engine
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: Verify search engine works
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Only adds new engine for Vietnamese build.
[String changes made/needed]:

Thank you team!  I would like to request uplift on this patch for 56.  The introduction of this popular search provider is low risk for us and we plan some social mentions and PR around the incorporation that we hope will benefit our end user engagement.  This is unique to the Vietnamese build.
Attachment #8886649 - Flags: approval-mozilla-beta?
[Tracking Requested - why for this release]: Would be helpful to get this in for a partner in Vietnam.

This is Vietnam only.
coccoc.com/search doesn't seem to work right now, I get "TypeError: a is undefined" in the console when visiting that.  Is it just me, or does it only work in Vietnam, or is it otherwise broken?
(In reply to Julien Cristau [:jcristau] from comment #13)
> coccoc.com/search doesn't seem to work right now, I get "TypeError: a is
> undefined" in the console when visiting that.  Is it just me, or does it
> only work in Vietnam, or is it otherwise broken?

It works fine for me from Italy.
And from Berlin.  Try http://coccoc.com/search#!
Comment on attachment 8886649 [details]
Bug 1380846 - Add coccoc to Vietnamese desktop build.

Seems to work for me now too.  OK, let's add this search plugin to the Vietnamese build for 55.0b13.
Attachment #8886649 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [bugday-20170719] → [bugday-20170719] [good first verify]
You need to log in before you can comment on or make changes to this bug.