1380849 - Please deploy autopush 1.33.0 to STAGE

Status: VERIFIED FIXED

(Cloud Services Graveyard :: Operations: Autopush, task)

Description

[Richard Pappalardo [:rpapa][:rpappalardo]]

------------------
RELEASE NOTES
------------------
https://github.com/mozilla-services/autopush/releases

COMPARISONS
https://github.com/mozilla-services/autopush/compare/1.32.0...1.32.1
https://github.com/mozilla-services/autopush/compare/1.32.1...1.32.2
https://github.com/mozilla-services/autopush/compare/1.32.2...1.33.0

TAGS
https://github.com/mozilla-services/autopush/releases/tag/1.33.0
https://github.com/mozilla-services/autopush/commit/d48ac40334c8f398e6bb8ab241e91cf886953649

CHANGELOG
<a name="1.33.0"></a>
## 1.33.0 (2017-07-12)


#### Features

*   Use modern metrics ([39db9a7d](https://github.com/mozilla-services/autopush/commit/39db9a7d821c4dc531fecbcf71ce4a3fd59a6d96), closes [#950](https://github.com/mozilla-services/autopush/issues/950))
*   Do not do VAPID auth on trusted connections ([f9b375a1](https://github.com/mozilla-services/autopush/commit/f9b375a1471d50d57c9d66d48928f14379f4d615), closes [#938](https://github.com/mozilla-services/autopush/issues/938))
*   Use cryptography from git to fix a memory leak ([615e961e](https://github.com/mozilla-services/autopush/commit/615e961e69b5d265fff8da3bf443c213ec37d0fd))
*   demote info to debug to reduce logging messages ([7b5d9d0f](https://github.com/mozilla-services/autopush/commit/7b5d9d0f59e662d247c90d2b52d9ce7359f05da0), closes [#936](https://github.com/mozilla-services/autopush/issues/936))
*   log EC2 instance ID when using AWS for hostname ([d8efd5e1](https://github.com/mozilla-services/autopush/commit/d8efd5e1b05cd68239eb9eeb34e21129f0361def), closes [#931](https://github.com/mozilla-services/autopush/issues/931))
*   accept aes128gcm content encoding ([00947d1f](https://github.com/mozilla-services/autopush/commit/00947d1f620d4b0ea451d2d16f23c45b8dca470b), closes [#930](https://github.com/mozilla-services/autopush/issues/930))

#### Refactor

*   convert PushState to attrs ([e96f8631](https://github.com/mozilla-services/autopush/commit/e96f8631147f5a2fa203dbf2bfebeaef5668ffc8), closes [#632](https://github.com/mozilla-services/autopush/issues/632))
*   convert AutopushSettings to attrs ([1616d245](https://github.com/mozilla-services/autopush/commit/1616d2454e88d4cd2b4a9a3b5c19c94a924088c8))
*   split clients and agent off settings ([70129bc2](https://github.com/mozilla-services/autopush/commit/70129bc257b6f64e84a243a2f2588333bee0d835))
*   begin tearing apart AutopushSettings ([fc66ddcc](https://github.com/mozilla-services/autopush/commit/fc66ddcc4819599f1c957eaaee181df09040b4a2))

#### Bug Fixes

*   add logging for register/unregister calls for websocket and bridges ([9e82e0d1](https://github.com/mozilla-services/autopush/commit/9e82e0d14a4664530a74bcdab06b1929cd41f8bd), closes [#953](https://github.com/mozilla-services/autopush/issues/953))
*   add memory pressure for jwt's cryptography usage ([99048cde](https://github.com/mozilla-services/autopush/commit/99048cde25c988ac7922b42a3d7e11043160fa55), closes [#917](https://github.com/mozilla-services/autopush/issues/917))
*   Return 400 if routing token is blank or unspecified ([910c7185](https://github.com/mozilla-services/autopush/commit/910c7185af0b9feb3ff77acbb6ad0b6fd611d889))

#### Chore

*   update to precise's latest pypy ([5e270934](https://github.com/mozilla-services/autopush/commit/5e270934a265fcc49201688c4df31326bb33cf07))

Comment 1

[Richard Pappalardo [:rpapa][:rpappalardo]]

This release has been tagged and auto-deployed to STAGE

----------------------------
URL CHECKS (STAGE)
----------------------------

curl -s 'https://updates-autopush.stage.mozaws.net/health' | python -mjson.tool
{
    "clients": 0,
    "stage.autopush.routerv2": {
        "status": "OK"
    },
    "stage.autopush.storage": {
        "status": "OK"
    },
    "status": "OK",
    "version": "1.33.0"
}


curl -s 'https://updates-autopush.stage.mozaws.net/status' | python -mjson.tool
{
    "status": "OK",
    "version": "1.33.0"
}

Comment 2

[Richard Pappalardo [:rpapa][:rpappalardo]]

-------------------------------------
iOS: SYNC + FxA + PUSH TEST (STAGE)
-------------------------------------

SETUP 

- Get account for buddybuild (from: njpark)
- Download “TestFlight” app
- Receive invite to use, enter code
- Get latest Beta Build (“click Update, if needed”)

- Create 2 new FxA accounts (1 for STAGE, 1 for PROD)
   https://accounts.stage.mozaws.net (STAGE)
- Login to desktop STAGE FxA account with a fresh firefox profile
- Save some bookmarks and create some navigation history

TEST STEPS (STR)
- Go to settings in new download of Firefox iOS app
- Click on Version info 5x, to enable STAGE server toggle switch
- Flip toggle to point to STAGE server(s)
- Login to new FxA (STAGE) account
- wait or force sync activity
- Observe bookmarks and history appear in Firefox browser

RESULTS
- Test succeeds using PROD settings, but currently not working w/ STAGE
- I verified w/ jrgm that FxA STAGE login is successfully landing in FxA stage database and also reaching token server
- However, sync activity on STAGE isn't currently working
- probably OK to proceed with push deploy and simply do the iOS test for PROD release only

Comment 3

[Chris Hartjes [:grumpy][:chartjes]]

URL checks pass

(venv)  ✘ chartjes@grumpiermbp  ~/mozilla-services/autopush-deployment-tests   master ●✚  py.test -v --api-version=1.33.0 --env=stage tests/test_urls.py
============================================================== test session starts ===============================================================
platform darwin -- Python 3.6.1, pytest-3.1.2, py-1.4.34, pluggy-0.4.0 -- /Users/chartjes/mozilla-services/autopush-deployment-tests/venv/bin/python3.6
cachedir: .cache
rootdir: /Users/chartjes/mozilla-services/autopush-deployment-tests, inifile:
collected 2 items

tests/test_urls.py::test_health PASSED
tests/test_urls.py::test_status PASSED


Sentry test passed, generated expected logging error

updates-autopush.stage.mozaws.net
{
    "code": 418,
    "errno": 999,
    "error": "Test Failure",
    "message": "FAILURE:Success",
    "more_info": "http://autopush.readthedocs.io/en/latest/http.html#error-codes"
}


Topics tests passed



{'ami_id': 'ami-46beb250', 'authorization': [Filtered], 'message_ttl': None, 'python_version': '2.7.13 (c925e7381036, Jun 05 2017, 21:20:51)
[PyPy 5.8.0 with GCC 6.2.0 20160901]', 'remote_ip': '72.39.64.107, 172.31.7.160', 'request_id': 'a5ea2cef-e414-45e3-9583-b0819c7f1130', 'uri': '/v1/err/crit', 'user_agent': 'curl/7.51.0'}

Comment 4

[Chris Hartjes [:grumpy][:chartjes]]

----------------------------
E2E-TESTS: VAPID (+Android)
----------------------------

Additional E2E-test which includes VAPID, encryption:
https://jrconlin.github.io/Webpush_QA/

Android (Nightly, Release) -- OK

NOTE:

This page can also be used to test Android, however, 
on STAGE / PROD gcm path + senderID must be appended (see below).
oremj> the sender ids are 965234145045 and 829133274407 (for both STAGE & PROD)

 
STAGE:
dom.push.serverURL = https://updates-autopush.stage.mozaws.net/v1/gcm/829133274407

PROD:
dom.push.serverURL = https://updates.push.services.mozilla.com/v1/gcm/829133274407


unlike paths for desktop (uses sockets):

STAGE:
dom.push.serverURL = wss://autopush.stage.mozaws.net/

PROD:
dom.push.serverURL = wss://push.services.mozilla.com/

Comment 5

[Chris Hartjes [:grumpy][:chartjes]]

----------------------------
E2E-TESTS
----------------------------

setting STAGE config to:
dom.push.serverURL = autopush.stage.mozaws.net

DESKTOP E2E PUSH TEST

setup:
start browser with new profile
open: about:config
set: dom.push.loglevel=debug (instead of 'off')
open: Tools > WebDeveloper > BrowserConsole
open: https://mozilla-services.github.io/autopush-e2e-test/
choose: "service-worker.js"
click: "register Service Worker"
click: "subscribe to push"
observe push registration in console
click: "Always Receive Notifications" (in pop-up window)

1. registration test

steps:
click: "XHR to webpush app-server"
observe: successful registration in console

2. message delivery test

setup:
set: Repeat = 2
set: Delay (seconds) = 15

steps:
click: "XHR to webpush app-server"
observe: 2 pop notifications 15 seconds apart
 
3. payload test

setup:
set: Title = PAYLOAD TEST
set: Body = BODY TEXT HERE
set: TTL = 360
set: Repeat = 4
set: Delay (seconds): 20

steps:
click: "XHR to webpush app-server"
observe:
should see delayed pop notifications with Title, Body specified

4. storage test

purpose: verify that a request is stored on autopush for delayed delivery

setup:
(same as 3 above)

steps:
click: "XHR to webpush app-server
wait for pop notification, then immediately close browser
wait 25 seconds
re-open browser
observe:
should see 3 more delayed messages delivered on browser restart

Comment 6

[Chris Hartjes [:grumpy][:chartjes]]

----------------------------
SCENARIO TESTING 
see: https://github.com/mozilla-services/ap-loadtester/
----------------------------

MULTI-SCENARIO (SOAK) TESTS

[0]. basic
[1]. api_test
[2]. loadtest

All appear to have passed.

QA approves the stage deployment and is set for a production deployment