138086 - LDAP over SSL autocomplete crash [@ nsLDAPConnection::AddPendingOperation(nsILDAPOperation*)] (v3), [@ nsLDAPConnection::AddPendingOperation] (v2)

Status: RESOLVED FIXED

(MailNews Core :: LDAP Integration, defect, P3)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Talkback ID: 5314179

Stack looks like this:

nsLDAPConnection::AddPendingOperation()             
nsLDAPOperation::SimpleBind()
nsLDAPAutoCompleteSession::OnLDAPInit()
XPTC_InvokeByIndex()  
[etc]

I've seen this a few times, but have yet to be able to catch it with the debugger.

Comment 1

[Michael Buckland]

Discussed in mail news bug meeting with Engineering Marketing and PjM.  Decided
to plus this bug.  needinfo:  are you still seeing this?

Comment 2

[Michael Buckland]

Discussed at mail news bug meeting.  Decided to remove RTM from this bug.  This
means fixing this bug is currently not planned for RTM.

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

I haven't seen this recently, but I doubt it's because the bug has gone away.

Comment 4

[Chan Min Wai]

This didn't happen to me using Linux Mozilla 1.2.1 :)
Good news?

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Just saw this today using build 2005-09-18-05 on Windows XP SeaMonkey trunk.

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Assigning bugs that I'm not actively working on back to nobody; use SearchForThis as a search term if you want to delete all related bugmail at once.

Comment 7

[Wayne Mery (:wsmwk)]

These still exist on branch and trunk

TB41123847 is the only one with comments - "Was composing a new email and typing the address. TB then looked up in our company LDAP server (through SSL), popped up the dialog about expired certificate. When I clicked OK, it crashed."

nsLDAPConnection::AddPendingOperation()  [mozilla/directory/xpcom/base/src/nsLDAPConnection.cpp, line 380]
nsLDAPOperation::SimpleBind()  [mozilla/directory/xpcom/base/src/nsLDAPOperation.cpp, line 224]
nsLDAPAutoCompleteSession::OnLDAPInit()  [mozilla/xpfe/components/autocomplete/src/nsLDAPAutoCompleteSession.cpp, line 848]
XPTC_InvokeByIndex()
EventHandler()  [mozilla/xpcom/proxy/src/nsProxyEvent.cpp, line 158]
PL_HandleEvent()  [mozilla/xpcom/threads/plevent.c, line 688]
PL_ProcessPendingEvents()  [mozilla/xpcom/threads/plevent.c, line 623]
nsEventQueueImpl::ProcessPendingEvents()  [mozilla/xpcom/threads/nsEventQueue.cpp, line 452]
event_processor_callback()  [mozilla/widget/src/gtk2/nsAppShell.cpp, line 71]
libglib-2.0.so.0 + 0x4c99f (0x006aa99f)
libglib-2.0.so.0 + 0x28385 (0x00686385)
libglib-2.0.so.0 + 0x29c35 (0x00687c35)
libglib-2.0.so.0 + 0x29e8c (0x00687e8c)
libgtk-x11-2.0.so.0 + 0x10a517 (0x00313517)
nsAppShell::Run()  [mozilla/widget/src/gtk2/nsAppShell.cpp, line 141]
nsAppStartup::Run()  [mozilla/toolkit/components/startup/src/nsAppStartup.cpp, line 152]
XRE_main()  [mozilla/toolkit/xre/nsAppRunner.cpp, line 848]
main()  [mozilla/mail/app/nsMailApp.cpp, line 63]
libc.so.6 + 0x14de3 (0x03cb9de3)

TB43694511 has shorter stack

Comment 8

[Wayne Mery (:wsmwk)]

crash rank #169 for v3.0.3, similar stack. examined 8 of 200.

bp-81562743-b010-4733-bb47-903b92100406
0	thunderbird-bin	nsLDAPConnection::AddPendingOperation	directory/xpcom/base/src/nsLDAPConnection.cpp:394
1	thunderbird-bin	nsLDAPOperation::SimpleBind	directory/xpcom/base/src/nsLDAPOperation.cpp:337
2	thunderbird-bin	nsAbLDAPListenerBase::OnLDAPInit	mailnews/addrbook/src/nsAbLDAPListenerBase.cpp:323
3	thunderbird-bin	nsLDAPAutoCompleteSession::OnLDAPInit	mailnews/addrbook/src/nsLDAPAutoCompleteSession.cpp:444

Comment 9

[Magnus Melin [:mkmelin]]

http://hg.mozilla.org/releases/comm-1.9.1/annotate/7660bbbdfdc3/directory/xpcom/base/src/nsLDAPConnection.cpp#l394

mPendingOperations null?
which looks like it should be the case if the connection was closed

Comment 10

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Comment 11

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 444316 [details] [diff] [review]
proposed fix

r+sr=dmose.  Bonus points for adding a unit test, but since this is a band-aid fix for a known crasher, I think it's ok for this to land without that if you don't have the bandwidth.  In that case, please add in-testsuite? to this bug.

Thanks for the patch!

Comment 12

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 444316 [details] [diff] [review]
proposed fix

Also, a=thunderbird3.1.

Comment 13

[Mark Banner (:standard8)]

Checked in:
http://hg.mozilla.org/comm-central/rev/4ff61905f20f
http://hg.mozilla.org/releases/comm-1.9.2/rev/346c641be4cf