Closed Bug 1380867 Opened 2 years ago Closed 2 years ago

Add activeConsole to workerTargets

Categories

(DevTools :: Framework, enhancement)

enhancement
Not set

Tracking

(firefox56 fixed)

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed

People

(Reporter: jlast, Assigned: jlast)

Details

Attachments

(1 file, 1 obsolete file)

TabTarget has an activeConsole field for accessing the console actor. This adds an activeConsole getter to WorkerTarget to be symmetric.
Attached patch active-c.patch (obsolete) — Splinter Review
Attachment #8886415 - Flags: review?(bgrinstead)
Comment on attachment 8886415 [details] [diff] [review]
active-c.patch

Review of attachment 8886415 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/framework/target.js
@@ +836,5 @@
>      return this._workerClient;
>    },
>  
> +  get activeConsole() {
> +    return this.client._clients.get(this.form.consoleActor)

Nit: missing semicolon
Attached patch active-c-2.patchSplinter Review
Assignee: nobody → jlaster
Attachment #8886415 - Attachment is obsolete: true
Attachment #8886415 - Flags: review?(bgrinstead)
Attachment #8886448 - Flags: review?(bgrinstead)
You can count on me to mess up a one line change :P
Attachment #8886448 - Flags: review?(bgrinstead) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7745e88c7497
Add activeConsole to workerTargets. r=bgrins
Keywords: checkin-needed
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d8442daffab
Add activeConsole to workerTargets: Add semicolon after return statement to make eslint happy. r=eslint-fix
https://hg.mozilla.org/mozilla-central/rev/7745e88c7497
https://hg.mozilla.org/mozilla-central/rev/8d8442daffab
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.