1380885 - Index more tasks by pushlog id

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Gregory Szorc [:gps]]

+++ This bug was initially created as a clone of Bug #1380391 +++

Let's double down on a good idea.

Comment 1

[Gregory Szorc [:gps]]

Attachment: Bug 1380885 - Index more tasks by pushlog id;

365731510976 (bug 1380391) added index routes for decision tasks by
pushlog id. This is a good idea. The pushlog id is guaranteed to always
be incrementing (except for repos that are periodically reset, which
we don't care about). It is useful to provide strict ordering for
pushes and is simpler for machines to consume and sort than dates.

So let's index all tasks by pushlog id.

Review commit: https://reviewboard.mozilla.org/r/157224/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157224/

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8886433 [details]
Bug 1380885 - Index more tasks by pushlog id;

https://reviewboard.mozilla.org/r/157224/#review162320

I know a lot less about the mozharness bit of this, but if you're confident, I'm a believer.

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8886433 [details]
Bug 1380885 - Index more tasks by pushlog id;

https://reviewboard.mozilla.org/r/157224/#review162320

I don't remember doing it, but annotate says I wrote the mozharness code. So, uh, I guess I'm confident in it :)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45c8fb17933b
Index more tasks by pushlog id; r=dustin

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/45c8fb17933b