If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

WebGL Conformance sdk/tests/conformance/state/gl-enable-enum-test.html

RESOLVED FIXED in Firefox 56

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: svargas, Assigned: svargas)

Tracking

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 months ago
Test:

https://www.khronos.org/registry/webgl/sdk/tests/conformance/state/gl-enable-enum-test.html?webglVersion=1&quiet=0

Failures:

FAIL gl.getParameter(gl.SAMPLE_ALPHA_TO_COVERAGE) should be true (of type boolean). Was null (of type object).
PASS gl.isEnabled(gl.SAMPLE_ALPHA_TO_COVERAGE) is false
FAIL gl.getParameter(gl.SAMPLE_ALPHA_TO_COVERAGE) should be false (of type boolean). Was null (of type object).
FAIL getError expected: NO_ERROR. Was INVALID_ENUM : gl.isEnabled and gl.GetParameter must not set errors when passed GL_SAMPLE_ALPHA_TO_COVERAGE
PASS getError was expected value: NO_ERROR : gl.enable must succeed when passed gl.SAMPLE_COVERAGE
PASS gl.isEnabled(gl.SAMPLE_COVERAGE) is true
FAIL gl.getParameter(gl.SAMPLE_COVERAGE) should be true (of type boolean). Was null (of type object).
PASS gl.isEnabled(gl.SAMPLE_COVERAGE) is false
FAIL gl.getParameter(gl.SAMPLE_COVERAGE) should be false (of type boolean). Was null (of type object).
FAIL getError expected: NO_ERROR. Was INVALID_ENUM : gl.isEnabled and gl.GetParameter must not set errors when passed 

These enums are missing in the WebGLContextState.cpp's getParameter function.
(Assignee)

Comment 1

2 months ago
Created attachment 8886439 [details] [diff] [review]
0001-Bug-1380891-WebGL-Conformance-sdk-tests-conformance-.patch

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=48d8ee3527a2732c413137657ffa03650dd53846
Assignee: nobody → svargas
Attachment #8886439 - Flags: review?(jgilbert)
Attachment #8886439 - Flags: review?(jgilbert) → review+
(Assignee)

Updated

2 months ago
Keywords: checkin-needed
In the future, please try to use commit messages for your patches which summarize what the patch is actually doing rather than simply restating the problem being fixed.
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html#write-detailed-commit-messages

Comment 3

2 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ebb04666500
WebGL Conformance sdk/tests/conformance/state/gl-enable-enum-test.html. r=jgilbert
Keywords: checkin-needed

Comment 4

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4ebb04666500
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.