1380891 - WebGL Conformance sdk/tests/conformance/state/gl-enable-enum-test.html

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, enhancement)

Description

[Samuel Vargas [:svargas]]

Test:

https://www.khronos.org/registry/webgl/sdk/tests/conformance/state/gl-enable-enum-test.html?webglVersion=1&quiet=0

Failures:

FAIL gl.getParameter(gl.SAMPLE_ALPHA_TO_COVERAGE) should be true (of type boolean). Was null (of type object).
PASS gl.isEnabled(gl.SAMPLE_ALPHA_TO_COVERAGE) is false
FAIL gl.getParameter(gl.SAMPLE_ALPHA_TO_COVERAGE) should be false (of type boolean). Was null (of type object).
FAIL getError expected: NO_ERROR. Was INVALID_ENUM : gl.isEnabled and gl.GetParameter must not set errors when passed GL_SAMPLE_ALPHA_TO_COVERAGE
PASS getError was expected value: NO_ERROR : gl.enable must succeed when passed gl.SAMPLE_COVERAGE
PASS gl.isEnabled(gl.SAMPLE_COVERAGE) is true
FAIL gl.getParameter(gl.SAMPLE_COVERAGE) should be true (of type boolean). Was null (of type object).
PASS gl.isEnabled(gl.SAMPLE_COVERAGE) is false
FAIL gl.getParameter(gl.SAMPLE_COVERAGE) should be false (of type boolean). Was null (of type object).
FAIL getError expected: NO_ERROR. Was INVALID_ENUM : gl.isEnabled and gl.GetParameter must not set errors when passed 

These enums are missing in the WebGLContextState.cpp's getParameter function.

Comment 1

[Samuel Vargas [:svargas]]

Attachment: 0001-Bug-1380891-WebGL-Conformance-sdk-tests-conformance-.patch

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=48d8ee3527a2732c413137657ffa03650dd53846

Comment 2

[Ryan VanderMeulen [:RyanVM]]

In the future, please try to use commit messages for your patches which summarize what the patch is actually doing rather than simply restating the problem being fixed.
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html#write-detailed-commit-messages

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ebb04666500
WebGL Conformance sdk/tests/conformance/state/gl-enable-enum-test.html. r=jgilbert

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4ebb04666500