1380898 - Account Settings Signature text box needs a minimum vertical height

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Pascal]

Attachment: ThunderbirdAccountSettings3.png

The Account Settings window automatically gets a vertical scrollbar as needed for short monitors.  Unfortunately, it first reduces the height of the Signature text box to the point that it is extremely difficult to use.

It would be nice if the Signature text box had a minimum height of at least two lines.

This problem is easy to reproduce on any monitor by dragging up the bottom of the Account Settings window.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug1380898.patch

This gives the signatureBox a minimal height which can't be undercut.

I added it directly to the XUL instead to the CSS files because this is more a flex change than a style change. I set 80px because when we have already a signature in the box which overflows we have scrollbars and make it tinier could lead us to see only the scrollbars.

Comment 2

[Richard Marti (:Paenglab)]

Ah, forgot: Sorry, the patch has a lot of whitespace changes. We should really cleanup mailnews like we've done for mail. What do you think?

Comment 3

[Jorg K (CEST = GMT+2)]

I'm having a bad time with this bug. I'm editing
C:\mozilla-source\comm-central\obj-x86_64-pc-mingw32\dist\bin\chrome\messenger\content\messenger\am-main.xul
to try various sizes but the changes don't take effect. In the end, I had to do a full build which takes 4 minutes.

I think 80px is much too high. I think 50px is OK, at that size you can fit two lines and the scroll bars are always visible.

Comment 4

[Richard Marti (:Paenglab)]

How about 60px?

Comment 5

[Jorg K (CEST = GMT+2)]

This is about a min-size, right? Not about a "best" size. 50px fits 2.5 lines and has a scrollbar. 60px fits tree lines which I think isn't necessary for minimum height.

Anyway, you're the UX boss, so if they are compelling reasons for 60px, I won't argue.

Comment 6

[Richard Marti (:Paenglab)]

Attachment: Bug1380898.patch

Okay, with min-height: 50px.

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 8886820 [details] [diff] [review]
Bug1380898.patch

Sure ;-)

Comment 8

[Richard Marti (:Paenglab)]

Thanks

Comment 9

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/4e29cdcef3791f27840b5eedd690dc7176c0417f

Comment 10

[Jorg K (CEST = GMT+2)]

Comment on attachment 8886820 [details] [diff] [review]
Bug1380898.patch

This is worth being uplifted since the totally collapsed box looks rather ugly.
Risk: Zero ;-)

Comment 11

[Jorg K (CEST = GMT+2)]

TB 52 ESR
https://hg.mozilla.org/releases/comm-esr52/rev/569d95e53a4c6e9f691abe81fcb79cd5fa46b223