1380949 - --disable-optimise build fails on Linux x86_64

Status: NEW

(Core :: XPConnect, defect, P3)

Description

[Julian Seward [:jseward]]

On Fedora 25, using clang 3.9, a build with the mozconfig shown below
fails.  The same thing with |ac_add_options --disable-optimize| replaced
by |ac_add_options --enable-optimize="-g -O2| works.  I am trying to do
a non-optimized build because some of the stack traces from an optimised
build are not adequate for investigating the stylo performance problems
in bug 1371496.

This is with a from-clean build.

--- MOZCONFIG ------------

. $topsrcdir/browser/config/mozconfig
mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/gcc-O0-nondebug-stylo
ac_add_options --enable-tests

ac_add_options --disable-optimize
ac_add_options --enable-debug-symbols

ac_add_options --enable-stylo

ac_add_options --enable-valgrind

ac_add_options --enable-profiling
ac_add_options --enable-elf-hack

ac_add_options --disable-crashreporter

mk_add_options MOZ_MAKE_FLAGS="-j8"
mk_add_options AUTOCLOBBER=1

--- HOW IT FAILS ------------

 0:19.32 Elapsed: 15.32s; From _tests: Kept 956 existing; Added/updated 0; Removed 1 files and 5 directories.
 0:21.95 Elapsed: 17.95s; From dist/bin: Kept 2273 existing; Added/updated 0; Removed 11 files and 0 directories.
 0:21.98 buildid.h
 0:21.98 source-repo.h
 0:22.65 application.ini
 0:23.16 application.ini.h
 0:24.13 Elapsed: 0.04s; From ../../dist/idl: Kept 1094 existing; Added/updated 0; Removed 0 files and 0 directories.
 0:31.51 force-cargo-library-build
 0:48.26     Finished release [optimized] target(s) in 0.35 secs
 0:49.64 libcaps_tests_gtest.a.desc
 0:49.85 libparser_xml.a.desc
 0:49.94 libparser_expat_lib.a.desc
 0:51.39 In file included from /space/MOZ/MC-STYLO/js/xpconnect/src/XPCThrower.cpp:12:0,
 0:51.40                  from /space/MOZ/MC-STYLO/gcc-O0-nondebug-stylo/js/xpconnect/src/Unified_cpp_js_xpconnect_src1.cpp:20:
 0:51.40 /space/MOZ/MC-STYLO/gcc-O0-nondebug-stylo/dist/include/mozilla/dom/BindingUtils.h: In function ‘nsresult mozilla::dom::binding_detail::UnwrapObjectInternal(V&, U&, mozilla::dom::prototypes::ID, uint32_t) [with T = mozilla::dom::Exception; bool mayBeWrapper = true; U = mozilla::dom::Exception*; V = mozilla::dom::binding_detail::MutableObjectHandleWrapper]’:
 0:51.40 /space/MOZ/MC-STYLO/gcc-O0-nondebug-stylo/dist/include/mozilla/dom/BindingUtils.h:254:1: error: inlining failed in call to always_inline ‘nsresult mozilla::dom::binding_detail::UnwrapObjectInternal(V&, U&, mozilla::dom::prototypes::ID, uint32_t) [with T = mozilla::dom::Exception; bool mayBeWrapper = false; U = mozilla::dom::Exception*; V = JSObject*]’: function not considered for inlining
 0:51.40  UnwrapObjectInternal(V& obj, U& value, prototypes::ID protoID,
 0:51.40  ^~~~~~~~~~~~~~~~~~~~
 0:51.40 /space/MOZ/MC-STYLO/gcc-O0-nondebug-stylo/dist/include/mozilla/dom/BindingUtils.h:291:67: note: called from here
 0:51.40                                                 protoID, protoDepth);
 0:51.40                                                                    ^
 0:51.40 /space/MOZ/MC-STYLO/config/rules.mk:1048: recipe for target 'Unified_cpp_js_xpconnect_src1.o' failed
 0:51.40 gmake[5]: *** [Unified_cpp_js_xpconnect_src1.o] Error 1
 0:51.40 gmake[5]: *** Waiting for unfinished jobs....

Comment 1

[Bobby Holley (:bholley)]

This doesn't look stylo related...

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Guessing XPConnect from the log.