Closed Bug 1380954 Opened 4 years ago Closed 4 years ago

Forward WebAuthnTransactionInfo::TimeoutMS() to U2F*TokenManagers

Categories

(Core :: DOM: Device Interfaces, enhancement)

Product:
Core
Component:
DOM: Device Interfaces
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: ttaubert, Assigned: ttaubert)

References

Details

(Whiteboard: [webauthn])

Attachments

(1 file)

0001-Bug-1380954-Forward-WebAuthnTransactionInfo-TimeoutM.patch
9.58 KB, patch
jcj
: review+
Details | Diff | Splinter Review 
The softoken implementation doesn't need a timeout, so the U2FTransport methods don't take a timeout argument. We need this for the USB token implementation though.
Comment on attachment 8886533 [details] [diff] [review]
0001-Bug-1380954-Forward-WebAuthnTransactionInfo-TimeoutM.patch

Review of attachment 8886533 [details] [diff] [review]:
-----------------------------------------------------------------

Simple; LGTM.
Attachment #8886533 - Flags: review?(jjones) → review+
Pushed by ttaubert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4b4898c8dc15
Forward WebAuthnTransactionInfo::TimeoutMS() to U2F*TokenManagers r=jcj
Attachment #8886533 - Flags: review?(kyle)
https://hg.mozilla.org/mozilla-central/rev/4b4898c8dc15
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.