Fennec Bookmark Management: wrong name displayed when editing folders

VERIFIED FIXED in Firefox 56

Status

()

Firefox for Android
General
VERIFIED FIXED
10 months ago
10 months ago

People

(Reporter: sorina, Assigned: jwu)

Tracking

(Blocks: 1 bug)

56 Branch
Firefox 56
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox56 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

10 months ago
Environment: 
Device: Asus Zenpad 8(Android 6.0.1);
Build: Nightly 56.0a1 (2017-07-13);

Steps to reproduce:
1. Go to Bookmarks Panel and add a folder A;
2. Long tap on folder A;
3. Tap on edit;

Expected result:
"Edit folder" name is displayed on top of the page.

Actual result:
"Edit bookmark" name is displayed on top of the page.

Comment 1

10 months ago
Could you please take a look at this? If a string change is required, we'd need to have it done ASAP.
Flags: needinfo?(topwu.tw)
Comment hidden (mozreview-request)
(Assignee)

Comment 3

10 months ago
Oops, sorry for missing this bug.
Assignee: nobody → topwu.tw
Flags: needinfo?(topwu.tw)

Comment 4

10 months ago
mozreview-review
Comment on attachment 8889131 [details]
Bug 1380983 - Show title as "Edit Folder" when editing a bookmark folder.

https://reviewboard.mozilla.org/r/160162/#review165536

Works for me. Wouldn't you want to remove default title from toolbar though? I'm not sure if that matters.
Attachment #8889131 - Flags: review?(gkruglov) → review+
Comment hidden (mozreview-request)
(Assignee)

Updated

10 months ago
Keywords: checkin-needed

Comment 6

10 months ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d1521ab5024f
Show title as "Edit Folder" when editing a bookmark folder. r=Grisha
Keywords: checkin-needed

Comment 7

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d1521ab5024f
Status: NEW → RESOLVED
Last Resolved: 10 months ago
status-firefox56: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
(Reporter)

Comment 8

10 months ago
Verified as fixed on build 56.0a1 (2017-07-25);
Device: Huawei MediaPad M2 (Android 5.1.1), LG G4 (Android 6.0.1).
Status: RESOLVED → VERIFIED
status-firefox56: fixed → verified
You need to log in before you can comment on or make changes to this bug.