1380983 - Fennec Bookmark Management: wrong name displayed when editing folders

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sorina Florean [:sflorean]]

Environment: 
Device: Asus Zenpad 8(Android 6.0.1);
Build: Nightly 56.0a1 (2017-07-13);

Steps to reproduce:
1. Go to Bookmarks Panel and add a folder A;
2. Long tap on folder A;
3. Tap on edit;

Expected result:
"Edit folder" name is displayed on top of the page.

Actual result:
"Edit bookmark" name is displayed on top of the page.

Comment 1

[:Grisha Kruglov]

Could you please take a look at this? If a string change is required, we'd need to have it done ASAP.

Comment 2

[Jing-wei Wu [:jwu]]

Attachment: Bug 1380983 - Show title as "Edit Folder" when editing a bookmark folder.

Review commit: https://reviewboard.mozilla.org/r/160162/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/160162/

Comment 3

[Jing-wei Wu [:jwu]]

Oops, sorry for missing this bug.

Comment 4

[:Grisha Kruglov]

Comment on attachment 8889131 [details]
Bug 1380983 - Show title as "Edit Folder" when editing a bookmark folder.

https://reviewboard.mozilla.org/r/160162/#review165536

Works for me. Wouldn't you want to remove default title from toolbar though? I'm not sure if that matters.

Comment 5

[Jing-wei Wu [:jwu]]

Comment on attachment 8889131 [details]
Bug 1380983 - Show title as "Edit Folder" when editing a bookmark folder.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/160162/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1521ab5024f
Show title as "Edit Folder" when editing a bookmark folder. r=Grisha

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d1521ab5024f

Comment 8

[Sorina Florean [:sflorean]]

Verified as fixed on build 56.0a1 (2017-07-25);
Device: Huawei MediaPad M2 (Android 5.1.1), LG G4 (Android 6.0.1).