1381010 - After resizing the window, open the onboarding overlay but the tours would not appear.

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[Fischer [:Fischer]]

Attachment: tours_disappear_after_resizing.gif

STR:
1. Open about:home or about:newtab
2. Click the onboarding fox icon to open the onboarding overlay
3. Make sure the tours appear
4. Resize the window so that the onboarding overlay and the fox icon disappear
5. Resize the window again so that the fox icon appears again
6. Click the onboarding fox icon to open the onboarding overlay

Expected result:
The tours appear again.

Actual result:
The tours do not appear.
See the attached tours_disappear_after_resizing.gif for the real action.

Root Cause:
We are doing lazy load of the tours [1], which is good. However, at the step 2, the tours got loaded into the overlay once so `_tourItems` would be loaded with tours. Then at the step 6 we thought the tours should be loaded already because
 `_tourItems` was not empty. But in fact, we destroyed the overlay and created one new overlay without any tour loaded.

[1] https://dxr.mozilla.org/mozilla-central/rev/30ea2905130e85f9e1d8d56fa3097901eec6514b/browser/extensions/onboarding/content/onboarding.js#413

Comment 1

[Fischer [:Fischer]]

Attachment: fix_tours_disappear_after_resizing.gif

Comment 2

[Fischer [:Fischer]]

Attachment: Bug 1381010 - After resizing the window, open the onboarding overlay but the tours would not appear.

Review commit: https://reviewboard.mozilla.org/r/157406/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157406/

Comment 3

[Fischer [:Fischer]]

(In reply to Fischer [:Fischer] from comment #2)
> Created attachment 8886585 [details]
> Bug 1381010 - After resizing the window, open the onboarding overlay but the
> tours would not appear.
> 
> Review commit: https://reviewboard.mozilla.org/r/157406/diff/#index_header
> See other reviews: https://reviewboard.mozilla.org/r/157406/
Hi Mossop,
Please see attachment 8886584 [details]: fix_tours_disappear_after_resizing.gif for the fix in action, thanks

Comment 4

[Dave Townsend [:mossop]]

Comment on attachment 8886585 [details]
Bug 1381010 - After resizing the window, open the onboarding overlay but the tours would not appear.

https://reviewboard.mozilla.org/r/157406/#review162566

Comment 5

[Fischer [:Fischer]]

Comment on attachment 8886585 [details]
Bug 1381010 - After resizing the window, open the onboarding overlay but the tours would not appear.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157406/diff/1-2/

Comment 6

[Fischer [:Fischer]]

Comment on attachment 8886585 [details]
Bug 1381010 - After resizing the window, open the onboarding overlay but the tours would not appear.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157406/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c94795e84153
After resizing the window, open the onboarding overlay but the tours would not appear. r=mossop

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c94795e84153

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I can still reproduce this bug after pull the latest Nightly. Could you confirm that?

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Sorry, false alarm.

Comment 11

[Justin [:JW_SoftvisionQA]]

I have verified that this bug is fixed with today's nightly.