test_bug631374_tags_selector_scroll.xul is failing for async PlacesTransactions

RESOLVED FIXED in Firefox 56

Status

()

Toolkit
Places
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

8 months ago
browser/components/places/tests/chrome/test_bug631374_tags_selector_scroll.xul is failing for async PlacesTransactions.

This was a result of https://hg.mozilla.org/integration/autoland/rev/c6ea57f05ae9 from bug 1379611.

There's various functions that are unnecessarily async, fixing those fixes the issue.
Comment hidden (mozreview-request)

Comment 2

8 months ago
mozreview-review
Comment on attachment 8886600 [details]
Bug 1381027 - Remove unnecessary async definitions for functions in editBookmarkOverlay.js.

https://reviewboard.mozilla.org/r/157418/#review162534

Thanks!
Attachment #8886600 - Flags: review?(mak77) → review+

Comment 3

8 months ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0d03e2cdfaf3
Remove unnecessary async definitions for functions in editBookmarkOverlay.js. r=mak

Comment 4

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0d03e2cdfaf3
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.