1381032 - about:addons search steals focus from add-on preferences textbox

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Ted Campbell [:tcampbell]]

STR:
1) Install Gecko Profiler from https://perf-html.io
2) Navigate to about:addons -> Extensions -> Gecko Profiler [Options]
3) Type a URL (containing forward slash) into |Profile viewer URL| box

Expected:
Can enter a URL including forward slashes

Actual:
A forward slash in URL appears in textbox, then focus switches to settings searchbar and rest of URL appears there.

Comment 1

[Ted Campbell [:tcampbell]]

mozregression range: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=392ed89ec2730a48d10b1cec741e86a242d28aa3&tochange=a625a2e9b3333a8e76982ea65f077cfded6ac224

Comment 2

[Ted Campbell [:tcampbell]]

Looks related to how OOP addons interact with Settings view.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

comment 0 refers to behavior happened on about:addons, unrelated to about:preferences.

Comment 5

[Andrew Swan [:aswan]]

Attachment: Bug 1381032 Ignore keypress events in about:addons when focus is in an embedded options browser

Review commit: https://reviewboard.mozilla.org/r/160686/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/160686/

Comment 6

[Gerry Chang [:gchang]]

Track 56+ as new regression.

Comment 7

[Kris Maglione [:kmag]]

Comment on attachment 8889645 [details]
Bug 1381032 Ignore keypress events in about:addons when focus is in an embedded options browser

https://reviewboard.mozilla.org/r/160686/#review167012

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/088f78b64f4a
Ignore keypress events in about:addons when focus is in an embedded options browser r=kmag

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/088f78b64f4a

Comment 10

[Bogdan Maris, Desktop Test Engineering]

I tested this bug using beta 56.0b2, beta 56.0b3 and latest Nightly (from 2017-08-16) on macOS 10.12 and Ubuntu 16.04 x64 and the bug is still reproducing. 

The first "/" you type appears into |Profile viewer URL| box, but the next thing you type (be it a number, symbol or letter) appears written in the settings searchbar. The only way I didn't manage to reproduce it is while I was testing it on Windows 10 x64 (using any build including nightly from 2017-08-02, 2017-07-14). Any thoughts on this?

Comment 11

[Andrew Swan [:aswan]]

Ah, I initially thought this was just about OOP, but it applies to both in-process and OOP.

It comes from this commit:
https://hg.mozilla.org/mozilla-central/rev/fa1b70cb9341

Before that changes, events from options pages never reached the parent page but now they do.  I'll try to come up with a new patch.

Comment 12

[Andrew Swan [:aswan]]

Taking the follow-up work to bug 1401018

Comment 13

[Oana Botisan, Desktop QA]

I managed to reproduce the bug using RC 56.0 - build 6 on Mac OS 10.11. This result is different only when you change the pref extensions.webextensions.remote to false. 

I retested everything on Mac OS 10.11 and Ubuntu 16.04x64 using latest Nightly and beta 57.0b5 and the bug is not reproducing anymore on this two builds.