about:addons search steals focus from add-on preferences textbox

RESOLVED FIXED in Firefox 56

Status

()

defect
P1
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: tcampbell, Assigned: aswan)

Tracking

({regression})

56 Branch
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox54 unaffected, firefox55 unaffected, firefox56+ fixed)

Details

Attachments

(1 attachment)

STR:
1) Install Gecko Profiler from https://perf-html.io
2) Navigate to about:addons -> Extensions -> Gecko Profiler [Options]
3) Type a URL (containing forward slash) into |Profile viewer URL| box

Expected:
Can enter a URL including forward slashes

Actual:
A forward slash in URL appears in textbox, then focus switches to settings searchbar and rest of URL appears there.
Looks related to how OOP addons interact with Settings view.
Version: unspecified → 56 Branch
Whiteboard: [photon-preference][triage]
comment 0 refers to behavior happened on about:addons, unrelated to about:preferences.
Summary: Setting search steals focus from settings textbox → about:addons search steals focus from add-on preferences textbox
Whiteboard: [photon-preference][triage]
Component: Preferences → Add-ons Manager
Product: Firefox → Toolkit
Assignee: nobody → aswan
Priority: -- → P1
Attachment #8889645 - Flags: review?(kmaglione+bmo)
Track 56+ as new regression.
Comment on attachment 8889645 [details]
Bug 1381032 Ignore keypress events in about:addons when focus is in an embedded options browser

https://reviewboard.mozilla.org/r/160686/#review167012
Attachment #8889645 - Flags: review?(kmaglione+bmo) → review+
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/088f78b64f4a
Ignore keypress events in about:addons when focus is in an embedded options browser r=kmag
https://hg.mozilla.org/mozilla-central/rev/088f78b64f4a
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Flags: qe-verify+
I tested this bug using beta 56.0b2, beta 56.0b3 and latest Nightly (from 2017-08-16) on macOS 10.12 and Ubuntu 16.04 x64 and the bug is still reproducing. 

The first "/" you type appears into |Profile viewer URL| box, but the next thing you type (be it a number, symbol or letter) appears written in the settings searchbar. The only way I didn't manage to reproduce it is while I was testing it on Windows 10 x64 (using any build including nightly from 2017-08-02, 2017-07-14). Any thoughts on this?
Flags: needinfo?(aswan)
Ah, I initially thought this was just about OOP, but it applies to both in-process and OOP.

It comes from this commit:
https://hg.mozilla.org/mozilla-central/rev/fa1b70cb9341

Before that changes, events from options pages never reached the parent page but now they do.  I'll try to come up with a new patch.
Status: RESOLVED → REOPENED
Flags: needinfo?(aswan)
Resolution: FIXED → ---
Blocks: 1401018
Taking the follow-up work to bug 1401018
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
I managed to reproduce the bug using RC 56.0 - build 6 on Mac OS 10.11. This result is different only when you change the pref extensions.webextensions.remote to false. 

I retested everything on Mac OS 10.11 and Ubuntu 16.04x64 using latest Nightly and beta 57.0b5 and the bug is not reproducing anymore on this two builds.
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.