1381156 - Make CHECK_PRINCIPAL_AND_DATA into a function or a template or something

Status: NEW

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Andrew McCreight [:mccr8]]

CHECK_PRINCIPAL_AND_DATA is a pretty gross macro. Maybe there's some kind of fancy C++ way to pass in a method we want to call. The same thing also goes for CHECK_CONTENT_POLICY_WITH_SERVICE and  CHECK_CONTENT_POLICY.

Comment 1

[Andrew Overholt [:overholt]]

Maybe we can do something special given the deprecation of NPAPI plugins?

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

AFAICT, we have to check principal/data in way more places than NPAPI (and there we do it as part of nsObjectLoadingContent, which is for more than plugins), so I'm not sure how NPAPI would affect this?

Comment 3

[Andrew Overholt [:overholt]]

Andrew mentioned something about this being related to plugins ...

Comment 4

[Andrew McCreight [:mccr8]]

Oh, sorry, I guess I was wrong that this was just something for plugins.

Comment 5

[Andrew Overholt [:overholt]]

Should we make this more than P3?

Comment 6

[Andrew McCreight [:mccr8]]

(In reply to Andrew Overholt [:overholt] from comment #5)
> Should we make this more than P3?

No, this is just a technical debt thing.