1381172 - Implement DrawTargetCapture::StrokeGlyphs

Status: RESOLVED FIXED

(Core :: Graphics, enhancement)

Description

[Mason Chang [Inactive] [:mchang]]

Attachment: Implement DrawTargetCapture::StrokeGlyphs

DrawTarget::StrokeGlyphs starts by getting a glyph as a path and strokes the path. DrawTargetCapture didn't override StrokeGlyphs, so we were replaying a path stroke to render some fonts.

Skia implements DrawTarget::StrokeGlyphs, but we weren't recording that. Hence the reftest failure was happening because OMTP would always replay stroke a path, when w/o OMTP, we'd have the test call StrokeGlyphs and the ref call stroke a path.

This bug implements DrawTargetCapture::StrokeGlyphs

Comment 1

[David Anderson [:dvander] - inactive, e-mail if emergency]

Comment on attachment 8886719 [details] [diff] [review]
Implement DrawTargetCapture::StrokeGlyphs

Review of attachment 8886719 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/DrawCommand.h
@@ +485,5 @@
> +    , mOptions(aOptions)
> +    , mRenderingOptions(const_cast<GlyphRenderingOptions*>(aRenderingOptions))
> +  {
> +    mGlyphs.resize(aBuffer.mNumGlyphs);
> +    memcpy(&mGlyphs.front(), aBuffer.mGlyphs, sizeof(Glyph) * aBuffer.mNumGlyphs);

If you want you can use PodCopy() here and below which is 2% safer.

Comment 2

[Mason Chang [Inactive] [:mchang]]

Try - https://treeherder.mozilla.org/#/jobs?repo=try&revision=e89237894b8aea85cd821e43ad9792f93b13761e

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6b6fb9ee1cfb
Implement DrawTargetCapture::StrokeGlyphs. r=dvander

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6b6fb9ee1cfb