1381175 - Display count of web content processes in about:support

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

This should count the number of processes dedicated to web content, and not include the other types of child processes (plugins, gfx, etc).

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1381175 - Display count of web content processes in about:support.

Review commit: https://reviewboard.mozilla.org/r/157516/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157516/

Comment 2

[:Felipe Gomes (needinfo for replies!)]

[Tracking Requested - why for this release]:
This information will be useful to let users easily see the current number of processes they are running with e10s multi

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8886721 [details]
Bug 1381175 - Display count of web content processes in about:support.

https://reviewboard.mozilla.org/r/157516/#review163210

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/af62be2909cf
Display count of web content processes in about:support. r=mrbkap

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8886721 [details]
Bug 1381175 - Display count of web content processes in about:support.

Approval Request Comment
[Feature/Bug causing the regression]: Display count of processes for e10s-multi
[User impact if declined]: No easy way to tell from within Firefox how many processes are being used
[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: No
[Why is the change risky/not risky?]: just change some information displayed in about:support
[String changes made/needed]: There is one new string ("Web Content Processes"), but we think we should uplift a hardcoded version of it (english-only) to have this included in about:support for 55. There's already a lot of text in about:support that is not localizable, and I think the benefits of this outweighs the untranslated string for one version.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/af62be2909cf

Comment 7

[Julien Cristau [:jcristau]]

I don't think I need to track this.

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 8886721 [details]
Bug 1381175 - Display count of web content processes in about:support.

add info about web content processes in about:support, beta55+

This needs a separate patch for beta with the english string hardcoded.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

(In reply to Julien Cristau [:jcristau] from comment #8)
> This needs a separate patch for beta with the english string hardcoded.

Needs rebasing anyway.

Comment 10

[:Felipe Gomes (needinfo for replies!)]

https://hg.mozilla.org/releases/mozilla-beta/rev/289f6e190f41c65a1099f71f37f0e657b2c7f16e

Comment 11

[Andrei Vaida [:avaida]]

(In reply to :Felipe Gomes (needinfo me!) from comment #5)
> [Is this code covered by automated tests?]: Yes
> [Has the fix been verified in Nightly?]: No
> [Needs manual test from QE? If yes, steps to reproduce]: No

Setting qe-verify- based on Felipe's assessment on manual testing needs and the fact that this fix has automated coverage.