1381216 - Crash in nsTArray_Impl<T>::SetLength<T> | nsUrlClassifierPrefixSet::LoadPrefixes

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect, P3)

Description

[baffclan]

This bug was filed from the Socorro interface and is 
report bp-fef5876d-5fdc-4678-bae3-32c630170715,
       bq-24edff31-8b7b-4e36-8ec0-d06590170715.
=============================================================

Crash when restart after a switch e10s.


Crashing Thread (47), Name: URL Classifier
Frame 	Module 	Signature 	Source
0 	xul.dll 	nsTArray_Impl<short, nsTArrayInfallibleAllocator>::SetLength<nsTArrayInfallibleAllocator>(unsigned __int64) 	obj-firefox/dist/include/nsTArray.h:1845
1 	xul.dll 	nsUrlClassifierPrefixSet::LoadPrefixes(nsIInputStream*) 	toolkit/components/url-classifier/nsUrlClassifierPrefixSet.cpp:448
2 	xul.dll 	nsUrlClassifierPrefixSet::LoadFromFile(nsIFile*) 	toolkit/components/url-classifier/nsUrlClassifierPrefixSet.cpp:349
3 	xul.dll 	mozilla::safebrowsing::LookupCache::LoadPrefixSet() 	toolkit/components/url-classifier/LookupCache.cpp:480
4 	xul.dll 	mozilla::safebrowsing::LookupCache::Open() 	toolkit/components/url-classifier/LookupCache.cpp:83
5 	xul.dll 	mozilla::safebrowsing::LookupCacheV2::Open() 	toolkit/components/url-classifier/LookupCache.cpp:552
6 	xul.dll 	mozilla::safebrowsing::Classifier::GetLookupCache(nsACString const&, bool) 	toolkit/components/url-classifier/Classifier.cpp:1466
7 	xul.dll 	mozilla::safebrowsing::Classifier::RegenActiveTables() 	toolkit/components/url-classifier/Classifier.cpp:929
8 	xul.dll 	mozilla::safebrowsing::Classifier::Open(nsIFile&) 	toolkit/components/url-classifier/Classifier.cpp:266
9 	xul.dll 	nsUrlClassifierDBServiceWorker::OpenDb() 	toolkit/components/url-classifier/nsUrlClassifierDBService.cpp:949
10 	xul.dll 	mozilla::detail::RunnableMethodImpl<RefPtr<nsUrlClassifierDBServiceWorker>, nsresult ( nsUrlClassifierDBServiceWorker::*)(void), 1, 0>::Run() 	obj-firefox/dist/include/nsThreadUtils.h:1187
11 	xul.dll 	nsThread::ProcessNextEvent(bool, bool*) 	xpcom/threads/nsThread.cpp:1437
12 	xul.dll 	NS_ProcessNextEvent(nsIThread*, bool) 	xpcom/threads/nsThreadUtils.cpp:489
13 	xul.dll 	mozilla::ipc::MessagePumpForNonMainThreads::Run(base::MessagePump::Delegate*) 	ipc/glue/MessagePump.cpp:339
14 	xul.dll 	MessageLoop::RunHandler() 	ipc/chromium/src/base/message_loop.cc:313
15 	xul.dll 	MessageLoop::Run() 	ipc/chromium/src/base/message_loop.cc:293
16 	xul.dll 	nsThread::ThreadFunc(void*) 	xpcom/threads/nsThread.cpp:506
17 	nss3.dll 	PR_NativeRunThread 	nsprpub/pr/src/threads/combined/pruthr.c:397
18 	nss3.dll 	pr_root 	nsprpub/pr/src/md/windows/w95thred.c:95
19 	ucrtbase.dll 	o__strtoui64 	
20 	kernel32.dll 	BaseThreadInitThunk 	
21 	ntdll.dll 	RtlUserThreadStart 	


Application Basics: 
Name: Firefox
Version: 56.0a1
Build ID: 20170714030205 	
Update Channel: nightly
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
OS: Windows_NT 10.0

Comment 1

[Selena Deckelmann :selenamarie :selena]

:francois this is a bit of a hail mary. Any thoughts on this crash?

Comment 2

[François Marier [:francois]]

The crash rate is pretty low (7 in the last month) and all in 55 or earlier.

Thomas, you've looked into a crash in LoadPrefixes() recently I think. Do you think this is a duplicate?

Comment 3

[Thomas Nguyen (:tnguyen)]

It should be fixed after we did refactor the usage of fallible alloc in bug 1378680.