Closed
Bug 1381242
Opened 7 years ago
Closed 7 years ago
Remove pre_compile workaround for buildpack cache ordering issue
Categories
(Tree Management :: Treeherder: Infrastructure, enhancement, P1)
Tree Management
Treeherder: Infrastructure
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: emorley)
Details
Attachments
(1 file)
A workaround was added to `bin/pre_compile` to handle the Python buildpack not restoring the cache in time for when the pre_compile script is run. That's now been fixed upstream: https://github.com/heroku/heroku-buildpack-python/pull/321 ...so the workaround must, since the it breaks when the bug is fixed. The only reason this hasn't affected us sooner, is that the library is cached from one build to the next - though we can't rely on that.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → emorley
Comment 1•7 years ago
|
||
Comment 2•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/5de04f59403de5b70a57e0b608d0b1f6079b81a6 Bug 1381242 - Heroku: Remove workaround for buildpack caching bug Since the Python buildpack now restores the cache prior to the `bin/pre_compile` script being run, which makes the workaround unnecessary and in fact breaks clean installs.
Assignee | ||
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•