Closed
Bug 1381293
Opened 7 years ago
Closed 7 years ago
Remove dom/base/test/test_intersectionobserver_no_root.html
Categories
(Core :: Layout, enhancement, P3)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: tschneider, Assigned: tschneider)
Details
Attachments
(1 file, 1 obsolete file)
2.36 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
dom/base/test/test_intersectionobserver_no_root.html was disabled in Bug 1369253 due to its instability. We do not plan to re-enable it, therefore it should be removed entirely.
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8886829 -
Attachment is obsolete: true
Updated•7 years ago
|
Priority: -- → P3
Assignee | ||
Comment 3•7 years ago
|
||
Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=08ac679b6b0ac7e1deb1114f7a3640357e3828d1
Assignee | ||
Comment 4•7 years ago
|
||
Comment on attachment 8886830 [details] [diff] [review] Remove test Blake, as discussed this is the patch that removes the test after being disabled in Bug 1369253.
Attachment #8886830 -
Flags: review?(mrbkap)
Updated•7 years ago
|
Attachment #8886830 -
Flags: review?(mrbkap) → review+
Pushed by tschneider@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e23128fe85f1 Remove dom/base/test/test_intersectionobserver_no_root.html. r=mrbkap
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e23128fe85f1
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Comment 7•7 years ago
|
||
(In reply to Tobias Schneider [:tobytailor] from comment #0) > dom/base/test/test_intersectionobserver_no_root.html was disabled in Bug > 1369253 due to its instability. We do not plan to re-enable it, therefore it > should be removed entirely. Which of the tests from bug 1358666 replaces this one?
Assignee | ||
Comment 8•7 years ago
|
||
Every single tests tests for the root bounds to be correct, but especially iframe-no-root.html. Notice that the really only reason we loaded this test in a separate window was to make sure the mochitest harness doesn't run it in a nested iframe.
Updated•6 years ago
|
Assignee: nobody → tschneider
You need to log in
before you can comment on or make changes to this bug.
Description
•