Closed Bug 1381356 Opened 4 years ago Closed 4 years ago
The onboarding notification button should not wrap
The "Learn More" button in the onboarding notifications wrap when you shrink the window width. This isn't necessary and looks bad. We should prevent it from wrapping.
Whiteboard: [photon-onboarding] → [photon-onboarding][triage]
Priority: -- → P1
QA Contact: jwilliams
Target Milestone: --- → Firefox 56
Assignee: fliu → rchien
Status: NEW → ASSIGNED
Whiteboard: [photon-onboarding][triage] → [photon-onboarding]
In order to avoid introducing a long button for certain specific language with using `white-space: nowrap`, we'd like to give a longer enough width `min-width: 130px` for fixing the text wrap issue at least for English.
Comment on attachment 8888186 [details] Bug 1381356 - The onboarding notification button should not wrap https://reviewboard.mozilla.org/r/159118/#review164804
Attachment #8888186 - Flags: review?(dtownsend) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/15085feea2b2 The onboarding notification button should not wrap r=mossop
I have reproduced this bug with nightly 56.0a1 (2017-07-16) on Linux Mint (64 Bit). The bug's fix is now verified on Latest Nightly 56.0a1 Build ID 20170727100240 User Agent Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0
QA Whiteboard: [bugday-20170726]
I have successfully reproduced this bug with Nightly 56.0a1 (2017-07-16) on windows 10(32bit) this bug is verified fix with latest nightly 56.0a1 (2017-07-27) (32-bit) Build ID: 20170727100347 Mozilla/5.0 (Windows NT 10.0; rv:56.0) Gecko/20100101 Firefox/56.0 [bugday-20170726]
You need to log in before you can comment on or make changes to this bug.