Closed
Bug 1381360
Opened 7 years ago
Closed 7 years ago
Make the speech bubbles 3px to the right of the fox icons
Categories
(Firefox :: General, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 56
Tracking | Status | |
---|---|---|
firefox56 | --- | verified |
People
(Reporter: verdi, Assigned: rexboy)
References
Details
(Whiteboard: [photon-onboarding])
Attachments
(2 files, 1 obsolete file)
The speech bubble in the onboarding notifications is missing a small triangle that points back at the fox.
Assignee | ||
Comment 1•7 years ago
|
||
Put it in triage. This is mainly because the rounded circle is easier to implement by just CSS and can be adapted to different size.
Whiteboard: [photon-onboarding] → [photon-onboarding][triage]
Comment 2•7 years ago
|
||
Whatever ended up landed in this bug please make sure it look alright in high contrast mode.
Updated•7 years ago
|
Flags: qe-verify+
Priority: -- → P2
QA Contact: jwilliams
Whiteboard: [photon-onboarding][triage] → [photon-onboarding]
Target Milestone: --- → Firefox 56
Reporter | ||
Comment 3•7 years ago
|
||
Fred pointed out to me some of the difficulties in making this work. Instead let's not use the little triangle and instead, set the speech bubble 3px to the right of the fox icon.
Attachment #8886901 -
Attachment is obsolete: true
Reporter | ||
Updated•7 years ago
|
Summary: Notification speech bubble is missing a triangle → Make the speech bubbles 3px to the right of the fox icons
Comment 4•7 years ago
|
||
Thank Verdi, that will be easier to implement. Rex, could you help integrate this spec into welcome message patch? (& dup this bug)
Flags: needinfo?(rexboy)
Assignee | ||
Comment 5•7 years ago
|
||
Solution included in another bug.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(rexboy)
Resolution: --- → DUPLICATE
Assignee | ||
Comment 7•7 years ago
|
||
Looks like we introduced a padding by changing icon from DIV to BUTTON such that the bubble and the fox stuck together again. (See bug 1377439) Let's have a quick patch to fix it.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Whiteboard: [photon-onboarding]
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → rexboy
Comment hidden (mozreview-request) |
Updated•7 years ago
|
Status: REOPENED → ASSIGNED
Priority: P2 → P1
Assignee | ||
Updated•7 years ago
|
Attachment #8889262 -
Flags: review?(dtownsend)
Assignee | ||
Comment 9•7 years ago
|
||
Per survey in bug 1383660, this patch may no longer valid. I'll update status as patch ready there.
Assignee | ||
Updated•7 years ago
|
Attachment #8889262 -
Flags: review?(dtownsend)
Assignee | ||
Comment 10•7 years ago
|
||
Seems the patch for 1383660 won't affect this bug. Mossop would you take a look for it? It's just a css one-liner.
Comment 11•7 years ago
|
||
mozreview-review |
Comment on attachment 8889262 [details] Bug 1381360 - Make the speech bubbles 3px to the right of the fox icons. https://reviewboard.mozilla.org/r/160312/#review166310
Attachment #8889262 -
Flags: review?(dtownsend) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 12•7 years ago
|
||
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/382ac74f97a2 Make the speech bubbles 3px to the right of the fox icons. r=mossop
Keywords: checkin-needed
Comment 13•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/382ac74f97a2
Status: ASSIGNED → RESOLVED
Closed: 7 years ago → 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Comment 14•7 years ago
|
||
Screenshots: https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=388d81ed93fa640f91d155f36254667c734157cf&newProject=mozilla-central&newRev=f1693d664f8e8ee4c79801630c181c28095cad56&filter=primaryUI
Comment 15•7 years ago
|
||
I have reproduced this bug with nightly 56.0a1 (2017-07-16) on Linux Mint (64 Bit). The bug's fix is now verified on Latest Nightly 56.0a1 Build ID 20170727100240 User Agent Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0
QA Whiteboard: [bugday-20170726]
Comment 16•7 years ago
|
||
I have successfully reproduced this bug with Nightly 56.0a1 (2017-07-16) on windows 10(32bit) this bug is verified fix with latest nightly 56.0a1 (2017-07-27) (32-bit) Build ID: 20170727100347 Mozilla/5.0 (Windows NT 10.0; rv:56.0) Gecko/20100101 Firefox/56.0 [bugday-20170726]
Updated•7 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•